]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
htp: fix potential (but unlikely) memleak in uri normalization
authorVictor Julien <victor@inliniac.net>
Tue, 23 Oct 2018 14:17:26 +0000 (16:17 +0200)
committerVictor Julien <victor@inliniac.net>
Thu, 1 Nov 2018 14:46:10 +0000 (15:46 +0100)
src/app-layer-htp-libhtp.c

index 3f040213fa99a139ab781923d9a8e13fd4dbdf55..a4ef784b0ed7c54d66b756ea8f5e4eb1c6f72ef8 100644 (file)
@@ -127,7 +127,7 @@ bstr *SCHTPGenerateNormalizedUri(htp_tx_t *tx, htp_uri_t *uri, int uri_include_a
                 bstr_add_noex(r, uri->username);
             }
 
-            bstr_add_c(r, ":");
+            bstr_add_c_noex(r, ":");
 
             if (uri->password != NULL) {
                 bstr_add_noex(r, uri->password);
@@ -141,7 +141,7 @@ bstr *SCHTPGenerateNormalizedUri(htp_tx_t *tx, htp_uri_t *uri, int uri_include_a
         }
 
         if (uri->port != NULL) {
-            bstr_add_c(r, ":");
+            bstr_add_c_noex(r, ":");
             bstr_add_noex(r, uri->port);
         }
     }