DoH: Remove unneeded isc__nmsocket_prep_destroy() call

This commit removes unneeded isc__nmsocket_prep_destroy() call on ALPN
negotiation failure, which was eventually causing the TLS handle to
leak.

This call is not needed, as not attaching to the transport (TLS)
handle should be enough. At this point it seems like a kludge from
earlier days of the TLS code.

diff --git a/lib/isc/netmgr/http.c b/lib/isc/netmgr/http.c
index 776f0e2b77d6d315ce9e2cd946365d1b50378974..466ae5497ac66e322237ed1928a09fbc0f516d69 100644 (file)
--- a/lib/isc/netmgr/http.c
+++ b/lib/isc/netmgr/http.c
@@ -1379,7 +1379,6 @@ transport_connect_cb(isc_nmhandle_t *handle, isc_result_t result, void *cbarg) {
                         * client will fail if HTTP/2 cannot be
                         * negotiated via ALPN.
                         */
-                       isc__nmsocket_prep_destroy(transp_sock);
                        result = ISC_R_HTTP2ALPNERROR;
                        goto error;
                }