]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/tuning: Use proper register offset for GAMSTLB_CTRL
authorMatt Roper <matthew.d.roper@intel.com>
Fri, 10 Apr 2026 22:50:29 +0000 (15:50 -0700)
committerMatt Roper <matthew.d.roper@intel.com>
Mon, 13 Apr 2026 19:41:56 +0000 (12:41 -0700)
From Xe2 onward (i.e., all platforms officially supported by the Xe
driver), the GAMSTLB_CTRL register is located at offset 0x477C and
represented by the macro "GAMSTLB_CTRL" in code.  However the register
formerly resided at offset 0xCF4C on Xe1-era platforms, and we also have
macro XEHP_GAMSTLB_CTRL that represents this old offset in the
unofficial/developer-only Xe1 code.  When tuning for the register was
added for Xe3p_LPG, the old Xe1-era macro was accidentally used instead
of the proper macro for Xe2 and beyond, causing the tuning to not be
applied properly.  Use the proper definition so that the correct offset
is written to.

Bspec: 59298
Fixes: 377c89bfaa5d ("drm/xe/xe3p_lpg: Set STLB bank hash mode to 4KB")
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Link: https://patch.msgid.link/20260410-xe3p_tuning-v1-2-e206a62ee38f@intel.com
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
drivers/gpu/drm/xe/xe_tuning.c

index ea48e2a60fcde062cf0efbbfcc61d86bd4c164a1..6fb8887d148286693941c696433e9482e0055713 100644 (file)
@@ -97,7 +97,7 @@ static const struct xe_rtp_entry_sr gt_tunings[] = {
        { XE_RTP_NAME("Tuning: Set STLB Bank Hash Mode to 4KB"),
          XE_RTP_RULES(GRAPHICS_VERSION_RANGE(3510, XE_RTP_END_VERSION_UNDEFINED),
                       IS_INTEGRATED),
-         XE_RTP_ACTIONS(FIELD_SET(XEHP_GAMSTLB_CTRL, BANK_HASH_MODE,
+         XE_RTP_ACTIONS(FIELD_SET(GAMSTLB_CTRL, BANK_HASH_MODE,
                                   BANK_HASH_4KB_MODE))
        },
 };