selftest: Create the cmd outside of the loop

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index 0ae1eceb7d46d25e7838e73b681f625e917d83b8..58beee5e8cafcd7a729b1feed758cb05385b75e7 100755 (executable)
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -3933,14 +3933,14 @@ sub wait_for_start($$$$$)
            print "wait for smbd\n";
 
            my $count = 0;
-           do {
-               if (defined($envvars->{GNUTLS_FORCE_FIPS_MODE})) {
+
+           if (defined($envvars->{GNUTLS_FORCE_FIPS_MODE})) {
                        # We don't have NTLM in FIPS mode, so lets use
                        # smbcontrol instead of smbclient.
                        $cmd = Samba::bindir_path($self, "smbcontrol");
                        $cmd .= " $envvars->{CONFIGURATION}";
                        $cmd .= " smbd ping";
-               } else {
+           } else {
                        # This uses NTLM which is not available in FIPS
                        $cmd = Samba::bindir_path($self, "smbclient");
                        $cmd .= " $envvars->{CONFIGURATION}";
@@ -3948,8 +3948,9 @@ sub wait_for_start($$$$$)
                        $cmd .= " -U%";
                        $cmd .= " -I $envvars->{SERVER_IP}";
                        $cmd .= " -p 139";
-               }
+           }
 
+           do {
                $ret = system($cmd);
                if ($ret != 0) {
                    sleep(1);