]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mei: vsc: Don't call vsc_tp_reset() a second time on shutdown
authorHans de Goede <hansg@kernel.org>
Mon, 23 Jun 2025 08:50:45 +0000 (10:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jun 2025 15:39:00 +0000 (16:39 +0100)
Now that mei_vsc_hw_reset() no longer re-inits the VSC when called from
mei_stop(), vsc_tp_shutdown() unregistering the platform-device, which
runs mei_stop() is sufficient to put the VSC in a clean state.

Signed-off-by: Hans de Goede <hansg@kernel.org>
Link: https://lore.kernel.org/r/20250623085052.12347-4-hansg@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/vsc-tp.c

index 99a55451e1fc8b852e99ab1ee9debf37b4fb0b50..4a262e2117e4430f92e4ac074b6e2bc8da4b339b 100644 (file)
@@ -547,8 +547,6 @@ static void vsc_tp_shutdown(struct spi_device *spi)
 
        mutex_destroy(&tp->mutex);
 
-       vsc_tp_reset(tp);
-
        free_irq(spi->irq, tp);
 }