]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: qcom: camss: csid-340: Fix unused variables
authorLoic Poulain <loic.poulain@oss.qualcomm.com>
Thu, 11 Dec 2025 13:59:39 +0000 (14:59 +0100)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 13 Jan 2026 09:25:01 +0000 (10:25 +0100)
The CSID driver has some unused variables and function parameters
that are no longer needed (due to refactoring). Clean up those
unused elements:

- Remove the `vc` parameter from `__csid_configure_rx()`.
- Drop the unused `lane_cnt` variable.
- Adjust call to `__csid_configure_rx()` accordingly.

Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/qcom/camss/camss-csid-340.c

index 22a30510fb7922eb8e7b222493e472a871c93cb8..2b50f9b96a34e3152f3daf00534f9f40d6bed1c0 100644 (file)
@@ -55,8 +55,7 @@
 #define CSID_RDI_CTRL_HALT_AT_FRAME_BOUNDARY           0
 #define CSID_RDI_CTRL_RESUME_AT_FRAME_BOUNDARY         1
 
-static void __csid_configure_rx(struct csid_device *csid,
-                               struct csid_phy_config *phy, int vc)
+static void __csid_configure_rx(struct csid_device *csid, struct csid_phy_config *phy)
 {
        u32 val;
 
@@ -81,13 +80,9 @@ static void __csid_configure_rdi_stream(struct csid_device *csid, u8 enable, u8
        const struct csid_format_info *format = csid_get_fmt_entry(csid->res->formats->formats,
                                                                   csid->res->formats->nformats,
                                                                   input_format->code);
-       u8 lane_cnt = csid->phy.lane_cnt;
        u8 dt_id;
        u32 val;
 
-       if (!lane_cnt)
-               lane_cnt = 4;
-
        /*
         * DT_ID is a two bit bitfield that is concatenated with
         * the four least significant bits of the five bit VC
@@ -120,10 +115,11 @@ static void csid_configure_stream(struct csid_device *csid, u8 enable)
 {
        int i;
 
+       __csid_configure_rx(csid, &csid->phy);
+
        for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS; i++) {
                if (csid->phy.en_vc & BIT(i)) {
                        __csid_configure_rdi_stream(csid, enable, i);
-                       __csid_configure_rx(csid, &csid->phy, i);
                        __csid_ctrl_rdi(csid, enable, i);
                }
        }