Bug 731727: Add support for RT to MoreBugUrl extension

r=timello, a=LpSolit

diff --git a/extensions/MoreBugUrl/Extension.pm b/extensions/MoreBugUrl/Extension.pm
index 7153165856a909e851631fd36087e71bb5d0708b..1ec2fcf16ece8d1790c2f71c38b3f08761f4eaa3 100644 (file)
--- a/extensions/MoreBugUrl/Extension.pm
+++ b/extensions/MoreBugUrl/Extension.pm
@@ -12,6 +12,7 @@ use base qw(Bugzilla::Extension);
 use constant MORE_SUB_CLASSES => qw(
     Bugzilla::Extension::MoreBugUrl::ReviewBoard
     Bugzilla::Extension::MoreBugUrl::Rietveld
+    Bugzilla::Extension::MoreBugUrl::RT
 );
 
 # We need to update bug_see_also table because both

diff --git a/extensions/MoreBugUrl/lib/RT.pm b/extensions/MoreBugUrl/lib/RT.pm
new file mode 100644 (file)
index 0000000..0d5faa2
--- /dev/null
+++ b/extensions/MoreBugUrl/lib/RT.pm
@@ -0,0 +1,37 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+# This Source Code Form is "Incompatible With Secondary Licenses", as
+# defined by the Mozilla Public License, v. 2.0.
+
+package Bugzilla::Extension::MoreBugUrl::RT;
+use strict;
+use base qw(Bugzilla::BugUrl);
+
+###############################
+####        Methods        ####
+###############################
+
+sub should_handle {
+    my ($class, $uri) = @_;
+
+    # RT URLs can look like various things:
+    #   http://example.com/rt/Ticket/Display.html?id=1234
+    #   https://example.com/Public/Bug/Display.html?id=1234
+    return ($uri->path =~ m|/Display.html$|
+            and $uri->query_param('id') =~ /^\d+$/) ? 1 : 0;
+}
+
+sub _check_value {
+    my $class = shift;
+
+    my $uri = $class->SUPER::_check_value(@_);
+
+    # And remove any # part if there is one.
+    $uri->fragment(undef);
+
+    return $uri;
+}
+
+1;

diff --git a/extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl b/extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl
index e0cf6be8e3c9d7a6cedec4ea703e5c48583637f9..979a9d5ddd1ec3036c310d5f7a6166786dd77ad5 100644 (file)
--- a/extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl
+++ b/extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl
@@ -8,3 +8,4 @@
 
 <li>A Review Board review request.</li>
 <li>An issue in a Rietveld installation.</li>
+<li>A ticket in an RT installation.</li>