]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
spi: spi-mux: Fix coverity issue, unchecked return value
authorSergio Perez Gonzalez <sperezglz@gmail.com>
Sun, 16 Mar 2025 05:46:06 +0000 (23:46 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 May 2025 09:12:40 +0000 (11:12 +0200)
[ Upstream commit 5a5fc308418aca275a898d638bc38c093d101855 ]

The return value of spi_setup() is not captured within
spi_mux_select() and it is assumed to be always success.

CID: 1638374

Signed-off-by: Sergio Perez Gonzalez <sperezglz@gmail.com>
Link: https://patch.msgid.link/20250316054651.13242-1-sperezglz@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-mux.c

index c02c4204442f5eb614a4231fa193e5efb887dd75..0eb35c4e3987ea4fa60047e69cb221cdd4cffe93 100644 (file)
@@ -68,9 +68,7 @@ static int spi_mux_select(struct spi_device *spi)
 
        priv->current_cs = spi_get_chipselect(spi, 0);
 
-       spi_setup(priv->spi);
-
-       return 0;
+       return spi_setup(priv->spi);
 }
 
 static int spi_mux_setup(struct spi_device *spi)