]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect/mpm: micro optimization in setup
authorVictor Julien <victor@inliniac.net>
Sun, 17 Dec 2017 19:08:12 +0000 (20:08 +0100)
committerVictor Julien <victor@inliniac.net>
Wed, 20 Dec 2017 09:50:42 +0000 (10:50 +0100)
src/detect-engine-mpm.c

index 845341fe9880a63a817964a2dee7bc3c89556d86..7bf4a74e998b3ead224d210861d133b60602ae63 100644 (file)
@@ -933,6 +933,8 @@ static void MpmStoreSetup(const DetectEngineCtx *de_ctx, MpmStore *ms)
             s = de_ctx->sig_array[sig];
             if (s == NULL)
                 continue;
+            if ((s->flags & ms->direction) == 0)
+                continue;
             if (s->init_data->mpm_sm == NULL)
                 continue;
             int list = SigMatchListSMBelongsTo(s, s->init_data->mpm_sm);
@@ -940,8 +942,6 @@ static void MpmStoreSetup(const DetectEngineCtx *de_ctx, MpmStore *ms)
                 continue;
             if (list != ms->sm_list)
                 continue;
-            if ((s->flags & ms->direction) == 0)
-                continue;
 
             SCLogDebug("adding %u", s->id);