Bug 897426: Revert the hack in Bugzilla->feature and make it more robust

r/a=glob

diff --git a/Bugzilla.pm b/Bugzilla.pm
index eb1c2f8eac223ce4750f2181b6f8e196aa441722..2c0e303d9a263ef144caa269412596f25ff441db 100644 (file)
--- a/Bugzilla.pm
+++ b/Bugzilla.pm
@@ -232,12 +232,7 @@ sub feature {
 
     my $success = 1;
     foreach my $module (@{ $feature_map->{$feature} }) {
-        # We can't use a string eval and "use" here (it kills Template-Toolkit,
-        # see https://rt.cpan.org/Public/Bug/Display.html?id=47929), so we have
-        # to do a block eval.
-        $module =~ s{::}{/}g;
-        $module .= ".pm";
-        eval { require $module; 1; } or $success = 0;
+        eval "require $module" or $success = 0;
     }
     $cache->{feature}->{$feature} = $success;
     return $success;