lxcapi_clone: exit early on snapshot clones

If the user explicitly asks for a snapshot clone (in which
case maybe_snap is not set), we cannot abide this currently.
Rather than exit later with more cryptic error messages, exit
out early.

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>

diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c
index 2c3388f59917af4c719188123a1bb6562b52323c..09b7ca73dac155c28023e2b582b6236f7e64ba32 100644 (file)
--- a/src/lxc/bdev.c
+++ b/src/lxc/bdev.c
@@ -2101,6 +2101,11 @@ struct bdev *bdev_copy(struct lxc_container *c0, const char *cname,
 
        /* check for privilege */
        if (am_unpriv()) {
+               if (snap && !maybe_snap) {
+                       ERROR("Unprivileged users cannot snapshot");
+                       bdev_put(orig);
+                       return NULL;
+               }
                if (bdevtype && strcmp(bdevtype, "dir") != 0) {
                        ERROR("Unprivileged users can only make dir copy-clones");
                        bdev_put(orig);