]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
usb: gadget: uvc: return error from uvcg_queue_init()
authorXu Yang <xu.yang_2@nxp.com>
Tue, 13 Jan 2026 09:53:09 +0000 (17:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jan 2026 15:03:18 +0000 (16:03 +0100)
uvcg_queue_init() may fail, but its return value is currently ignored.
Propagate the error code from uvcg_queue_init() to correctly report
initialization failures.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Link: https://patch.msgid.link/20260113-uvc-gadget-fix-patch-v2-3-62950ef5bcb5@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/uvc_video.c

index 9dc3af16e2f38957198bf579987f4324fc552c5d..f568dee08b3b7273be124a673682c02d20f7c77b 100644 (file)
@@ -838,7 +838,6 @@ int uvcg_video_init(struct uvc_video *video, struct uvc_device *uvc)
        video->interval = 666666;
 
        /* Initialize the video buffers queue. */
-       uvcg_queue_init(&video->queue, uvc->v4l2_dev.dev->parent,
+       return uvcg_queue_init(&video->queue, uvc->v4l2_dev.dev->parent,
                        V4L2_BUF_TYPE_VIDEO_OUTPUT, &video->mutex);
-       return 0;
 }