]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rtc: rzn1: clear interrupts on remove
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Wed, 12 Mar 2025 10:00:00 +0000 (11:00 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 8 Apr 2025 14:17:45 +0000 (16:17 +0200)
It is good practice to clear running interrupts before removing the
driver. This is not really a bugfix because on current systems RuntimePM
will disable the module clock, so interrupts won't be initiated. The
dependency on that behaviour is subtle, though. Better be self-contained
and clean up when removing.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20250312100105.36767-2-wsa+renesas@sang-engineering.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-rzn1.c

index eeb9612a666fd33515c3c698615288044e18672c..3c2861983ff1e2de35f0027d5441e503b5f79f40 100644 (file)
@@ -444,6 +444,11 @@ dis_runtime_pm:
 
 static void rzn1_rtc_remove(struct platform_device *pdev)
 {
+       struct rzn1_rtc *rtc = platform_get_drvdata(pdev);
+
+       /* Disable all interrupts */
+       writel(0, rtc->base + RZN1_RTC_CTL1);
+
        pm_runtime_put(&pdev->dev);
 }