]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
ci: make a build with ja disabled
authorPhilippe Antoine <pantoine@oisf.net>
Thu, 27 Mar 2025 19:40:42 +0000 (20:40 +0100)
committerVictor Julien <victor@inliniac.net>
Fri, 4 Apr 2025 00:35:14 +0000 (02:35 +0200)
Ticket: 7461

In order to run all SV tests in CI, including the ones that
require the abse,ce of the JA3 or JA4 feature

.github/workflows/builds.yml

index add1c0a25ee95c64c0c566c78e196ea48925e7bc..364e38cf0956e99e5a18deb59de3c340fc59ac97 100644 (file)
@@ -845,8 +845,10 @@ jobs:
   # This job builds and tests Suricata as a non-root user as some
   # issues only show up when not running as root, and by default all
   # jobs in GitHub actions are run as root inside the container.
+  # Also ja3 and ja4 are disabled to run SV tests that require
+  # the absence of these features
   fedora-non-root:
-    name: Fedora (non-root, debug, clang, asan, wshadow, rust-strict)
+    name: Fedora (non-root, debug, clang, asan, wshadow, rust-strict, no-ja)
     runs-on: ubuntu-latest
     container: fedora:41
     needs: [prepare-deps, prepare-cbindgen]
@@ -906,7 +908,10 @@ jobs:
       - run: sudo -u suricata -s ./autogen.sh
         working-directory: /home/suricata/suricata
 
-      - run: sudo -u suricata -s env PATH="/home/suricata/.cargo/bin:$PATH" ./configure --enable-warnings --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis --enable-nfqueue
+      - run: >-
+          sudo -u suricata -s env PATH="/home/suricata/.cargo/bin:$PATH" ./configure --enable-warnings
+          --enable-debug --enable-unittests --disable-shared --enable-rust-strict --enable-hiredis
+          --enable-nfqueue --disable-ja3 --disable-ja4
         working-directory: /home/suricata/suricata
         env:
           ac_cv_func_realloc_0_nonnull: "yes"
@@ -921,6 +926,12 @@ jobs:
       - run: sudo -u suricata -s make check
         working-directory: /home/suricata/suricata
 
+      - run: src/suricata --build-info | grep -E "JA3 support:\s+no" &> /dev/null
+        working-directory: /home/suricata/suricata
+
+      - run: src/suricata --build-info | grep -E "JA4 support:\s+no" &> /dev/null
+        working-directory: /home/suricata/suricata
+
       - run: sudo -u suricata -s python3 ./suricata-verify/run.py -q --debug-failed
         working-directory: /home/suricata/suricata