]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iio: imu: inv_icm42600: reorganize DMA aligned buffers in structure
authorJean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Mon, 30 Jun 2025 19:47:29 +0000 (21:47 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 14 Jul 2025 18:20:50 +0000 (19:20 +0100)
Move all DMA aligned buffers together at the end of the structure.

1. Timestamp anynomous structure is not used with DMA so it doesn't
belong after __aligned(IIO_DMA_MINALIGN).
2. struct inv_icm42600_fifo contains it's own __aligned(IIO_DMA_MINALIGN)
within it at the end so it should not be after __aligned(IIO_DMA_MINALIGN)
in the outer struct either.
3. Normally 1 would have been considered a bug, but because of the extra
alignment from 2, it actually was OK, but we shouldn't be relying on such
quirks.

Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Link: https://patch.msgid.link/20250630-losd-3-inv-icm42600-add-wom-support-v6-1-5bb0c84800d9@tdk.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/inv_icm42600/inv_icm42600.h

index 55ed1ddaa8cb5dd410d17db3866fa0f22f18e9d2..9b2cce172670c5513f18d5979a5ff563e9af4cb3 100644 (file)
@@ -148,9 +148,9 @@ struct inv_icm42600_suspended {
  *  @suspended:                suspended sensors configuration.
  *  @indio_gyro:       gyroscope IIO device.
  *  @indio_accel:      accelerometer IIO device.
- *  @buffer:           data transfer buffer aligned for DMA.
- *  @fifo:             FIFO management structure.
  *  @timestamp:                interrupt timestamps.
+ *  @fifo:             FIFO management structure.
+ *  @buffer:           data transfer buffer aligned for DMA.
  */
 struct inv_icm42600_state {
        struct mutex lock;
@@ -164,12 +164,12 @@ struct inv_icm42600_state {
        struct inv_icm42600_suspended suspended;
        struct iio_dev *indio_gyro;
        struct iio_dev *indio_accel;
-       u8 buffer[2] __aligned(IIO_DMA_MINALIGN);
-       struct inv_icm42600_fifo fifo;
        struct {
                s64 gyro;
                s64 accel;
        } timestamp;
+       struct inv_icm42600_fifo fifo;
+       u8 buffer[2] __aligned(IIO_DMA_MINALIGN);
 };