Free memory on instantiation error

diff --git a/src/modules/rlm_perl/rlm_perl.c b/src/modules/rlm_perl/rlm_perl.c
index c00e31c64e8d418a139fd87f4f05b4f6162e75de..ec57e9a77e316469d3f7f961fd57f76112b178fa 100644 (file)
--- a/src/modules/rlm_perl/rlm_perl.c
+++ b/src/modules/rlm_perl/rlm_perl.c
@@ -430,6 +430,7 @@ static int perl_instantiate(CONF_SECTION *conf, void **instance)
         *      fail.
         */
        if (cf_section_parse(conf, inst, module_config) < 0) {
+               free(embed);
                free(inst);
                return -1;
        }
@@ -460,6 +461,8 @@ static int perl_instantiate(CONF_SECTION *conf, void **instance)
 #ifdef USE_ITHREADS
        if ((inst->perl = perl_alloc()) == NULL) {
                radlog(L_DBG, "rlm_perl: No memory for allocating new perl !");
+               free(embed);
+               free(inst);
                return (-1);
        }
 
@@ -473,6 +476,8 @@ static int perl_instantiate(CONF_SECTION *conf, void **instance)
 #else
        if ((inst->perl = perl_alloc()) == NULL) {
                radlog(L_ERR, "rlm_perl: No memory for allocating new perl !");
+               free(embed);
+               free(inst);
                return -1;
        }
 
@@ -492,6 +497,8 @@ static int perl_instantiate(CONF_SECTION *conf, void **instance)
                exitstatus = perl_run(inst->perl);
        } else {
                radlog(L_ERR,"rlm_perl: perl_parse failed: %s not found or has syntax errors. \n", inst->module);
+               free(embed);
+               free(inst);
                return (-1);
        }