]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: rtlwifi: use convenient list_count_nodes()
authorDmitry Antipov <dmantipov@yandex.ru>
Wed, 11 Oct 2023 04:52:01 +0000 (07:52 +0300)
committerKalle Valo <kvalo@kernel.org>
Thu, 12 Oct 2023 12:13:48 +0000 (15:13 +0300)
Simplify 'rtl92ee_dm_common_info_self_update()',
'rtl8723be_dm_common_info_self_update()', and
'rtl8821ae_dm_common_info_self_update()' by using
'list_count_nodes()'. Compile tested only.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20231011045227.7989-1-dmantipov@yandex.ru
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/dm.c
drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c

index 997ff115b9abc2b8e5b880119e60516ccf7e1f15..5a828a934fe9b1bf0da0ccf2242a7e9df60ee66f 100644 (file)
@@ -936,8 +936,7 @@ void rtl92ee_dm_init(struct ieee80211_hw *hw)
 static void rtl92ee_dm_common_info_self_update(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-       struct rtl_sta_info *drv_priv;
-       u8 cnt = 0;
+       u8 cnt;
 
        rtlpriv->dm.one_entry_only = false;
 
@@ -951,9 +950,7 @@ static void rtl92ee_dm_common_info_self_update(struct ieee80211_hw *hw)
            rtlpriv->mac80211.opmode == NL80211_IFTYPE_ADHOC ||
            rtlpriv->mac80211.opmode == NL80211_IFTYPE_MESH_POINT) {
                spin_lock_bh(&rtlpriv->locks.entry_list_lock);
-               list_for_each_entry(drv_priv, &rtlpriv->entry_list, list) {
-                       cnt++;
-               }
+               cnt = list_count_nodes(&rtlpriv->entry_list);
                spin_unlock_bh(&rtlpriv->locks.entry_list_lock);
 
                if (cnt == 1)
index c3c990cc032fa80a182fd2318b066c695680598c..c53f95144812fc5f40c84562aebf919003f61450 100644 (file)
@@ -1210,8 +1210,7 @@ static void rtl8723be_dm_dynamic_atc_switch(struct ieee80211_hw *hw)
 static void rtl8723be_dm_common_info_self_update(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-       u8 cnt = 0;
-       struct rtl_sta_info *drv_priv;
+       u8 cnt;
 
        rtlpriv->dm.one_entry_only = false;
 
@@ -1225,9 +1224,7 @@ static void rtl8723be_dm_common_info_self_update(struct ieee80211_hw *hw)
                rtlpriv->mac80211.opmode == NL80211_IFTYPE_ADHOC ||
                rtlpriv->mac80211.opmode == NL80211_IFTYPE_MESH_POINT) {
                spin_lock_bh(&rtlpriv->locks.entry_list_lock);
-               list_for_each_entry(drv_priv, &rtlpriv->entry_list, list) {
-                       cnt++;
-               }
+               cnt = list_count_nodes(&rtlpriv->entry_list);
                spin_unlock_bh(&rtlpriv->locks.entry_list_lock);
 
                if (cnt == 1)
index f3fe16798c591b34d23256198fa1925d2eefc1ef..76b5395539d0eb9b20a6056359f7d1734697f8cc 100644 (file)
@@ -827,8 +827,7 @@ static void rtl8821ae_dm_dig(struct ieee80211_hw *hw)
 static void rtl8821ae_dm_common_info_self_update(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-       u8 cnt = 0;
-       struct rtl_sta_info *drv_priv;
+       u8 cnt;
 
        rtlpriv->dm.tx_rate = 0xff;
 
@@ -844,8 +843,7 @@ static void rtl8821ae_dm_common_info_self_update(struct ieee80211_hw *hw)
            rtlpriv->mac80211.opmode == NL80211_IFTYPE_ADHOC ||
            rtlpriv->mac80211.opmode == NL80211_IFTYPE_MESH_POINT) {
                spin_lock_bh(&rtlpriv->locks.entry_list_lock);
-               list_for_each_entry(drv_priv, &rtlpriv->entry_list, list)
-                       cnt++;
+               cnt = list_count_nodes(&rtlpriv->entry_list);
                spin_unlock_bh(&rtlpriv->locks.entry_list_lock);
 
                if (cnt == 1)