Expand filename (#7893)

* Fix double env
* Properly expand name in attach step
* Update maintaining docs

diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml
index f674ecd4fdda364b638f349b3859ed4896058883..637f74462292717d1bb3cacebe416d7c4ec6e07f 100644 (file)
--- a/.github/workflows/npmpublish.yml
+++ b/.github/workflows/npmpublish.yml
@@ -68,6 +68,6 @@ jobs:
           VERSION: ${{ github.event.release.tag_name }}
         with:
           upload_url: ${{ github.event.release.upload_url }}
-          asset_path: chart.js-$VERSION.tgz
-          asset_name: chart.js-$VERSION.tgz
+          asset_path: ${{ format('chart.js-{0}.tgz', github.event.release.tag_name) }}
+          asset_name: ${{ format('chart.js-{0}.tgz', github.event.release.tag_name) }}
           asset_content_type: application/gzip

diff --git a/MAINTAINING.md b/MAINTAINING.md
index 894d912b72f8e7212dcfb7da3ff5e1ccb6e3abf1..a819bef2bdd61f0a1649ec0968d776a9c9bb4399 100644 (file)
--- a/MAINTAINING.md
+++ b/MAINTAINING.md
@@ -4,32 +4,20 @@ Chart.js relies on [Travis CI](https://travis-ci.org/) to automate the library [
 
 ### Releasing a New Version
 
-1. draft release notes on [GitHub](https://github.com/chartjs/Chart.js/releases/new) for the upcoming tag
-1. update `master` `package.json` version using [semver](https://semver.org/) semantic
-1. merge `master` into the `release` branch
-1. follow the build process on [Travis CI](https://travis-ci.org/chartjs/Chart.js)
-
-> **Note:** if `master` is merged in `release` with a `package.json` version that already exists, the tag
-creation fails and the release process is aborted.
-
-### Automated Tasks
-Merging into the `release` branch kicks off the automated release process:
-
-* build of the `dist/*.js` files
-* `dist/*.js` is added to a detached branch
-* a tag is created from the `package.json` version
-* tag (with dist files) is pushed to GitHub
+1. Update the release version on [GitHub](https://github.com/chartjs/Chart.js/releases/new) for the release drafted by the `release-drafter` tool
+2. Publish the release
+3. follow the build process on [GitHub Actions](https://github.com/chartjs/Chart.js/actions?query=workflow%3A%22Node.js+Package%22)
 
 Creation of this tag triggers a new build:
 
 * `Chart.js.zip` package is generated, containing dist files and examples
 * `dist/*.js` and `Chart.js.zip` are attached to the GitHub release (downloads)
-* a new npm package is published on [npmjs](https://www.npmjs.com/package/chart.js)
+* A new npm package is published on [npmjs](https://www.npmjs.com/package/chart.js)
 
 Finally, [cdnjs](https://cdnjs.com/libraries/Chart.js) is automatically updated from the npm release.
 
 ### Further Reading
 
-* [Travis GitHub releases](https://github.com/chartjs/Chart.js/pull/2555)
+* [GitHub Action releases](https://github.com/chartjs/Chart.js/pull/7891)
 * [dist/* files](https://github.com/chartjs/Chart.js/issues/3033)
 * [cdnjs npm auto update](https://github.com/cdnjs/cdnjs/pull/8401)