]> git.ipfire.org Git - thirdparty/git.git/commitdiff
daemon: remove unnecesary restriction for listener fd
authorCarlo Marcelo Arenas Belón <carenas@gmail.com>
Thu, 26 Jun 2025 09:51:39 +0000 (02:51 -0700)
committerJunio C Hamano <gitster@pobox.com>
Thu, 26 Jun 2025 15:35:08 +0000 (08:35 -0700)
Since df076bdbcc ([PATCH] GIT: Listen on IPv6 as well, if available.,
2005-07-23), any file descriptor assigned to a listening socket was
validated to be within the range to be used in an FDSET later.

6573faff34 (NO_IPV6 support for git daemon, 2005-09-28), moves to
use poll() instead of select(), that doesn't have that restriction,
so remove the original check.

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Acked-by: Phillip Wood <phillip.wood123@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
daemon.c

index d1be61fd578949385c94e590ca3b7ba7c09048d2..99741f0b45572ff9803907ecefc583c4f6b9079e 100644 (file)
--- a/daemon.c
+++ b/daemon.c
@@ -990,11 +990,6 @@ static int setup_named_sock(char *listen_addr, int listen_port, struct socketlis
                sockfd = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol);
                if (sockfd < 0)
                        continue;
-               if (sockfd >= FD_SETSIZE) {
-                       logerror("Socket descriptor too large");
-                       close(sockfd);
-                       continue;
-               }
 
 #ifdef IPV6_V6ONLY
                if (ai->ai_family == AF_INET6) {