]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
leds: lp8860: Remove default regs when not caching
authorAndrew Davis <afd@ti.com>
Mon, 7 Apr 2025 18:35:52 +0000 (13:35 -0500)
committerLee Jones <lee@kernel.org>
Wed, 14 May 2025 08:24:53 +0000 (09:24 +0100)
If we are not using regmap caches, then the value will be read
in every time, having a default value does not change anything in
that case. Remove the unused defaults.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20250407183555.409687-3-afd@ti.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-lp8860.c

index 2d91f476f0b79e19ac719b223181b40060106e12..4cd1b960d504fb1401db3e8699993ffcd54eafe0 100644 (file)
@@ -292,61 +292,11 @@ out:
        return ret;
 }
 
-static const struct reg_default lp8860_reg_defs[] = {
-       { LP8860_DISP_CL1_BRT_MSB, 0x00},
-       { LP8860_DISP_CL1_BRT_LSB, 0x00},
-       { LP8860_DISP_CL1_CURR_MSB, 0x00},
-       { LP8860_DISP_CL1_CURR_LSB, 0x00},
-       { LP8860_CL2_BRT_MSB, 0x00},
-       { LP8860_CL2_BRT_LSB, 0x00},
-       { LP8860_CL2_CURRENT, 0x00},
-       { LP8860_CL3_BRT_MSB, 0x00},
-       { LP8860_CL3_BRT_LSB, 0x00},
-       { LP8860_CL3_CURRENT, 0x00},
-       { LP8860_CL4_BRT_MSB, 0x00},
-       { LP8860_CL4_BRT_LSB, 0x00},
-       { LP8860_CL4_CURRENT, 0x00},
-       { LP8860_CONFIG, 0x00},
-       { LP8860_FAULT_CLEAR, 0x00},
-       { LP8860_EEPROM_CNTRL, 0x80},
-       { LP8860_EEPROM_UNLOCK, 0x00},
-};
-
 static const struct regmap_config lp8860_regmap_config = {
        .reg_bits = 8,
        .val_bits = 8,
 
        .max_register = LP8860_EEPROM_UNLOCK,
-       .reg_defaults = lp8860_reg_defs,
-       .num_reg_defaults = ARRAY_SIZE(lp8860_reg_defs),
-};
-
-static const struct reg_default lp8860_eeprom_defs[] = {
-       { LP8860_EEPROM_REG_0, 0x00 },
-       { LP8860_EEPROM_REG_1, 0x00 },
-       { LP8860_EEPROM_REG_2, 0x00 },
-       { LP8860_EEPROM_REG_3, 0x00 },
-       { LP8860_EEPROM_REG_4, 0x00 },
-       { LP8860_EEPROM_REG_5, 0x00 },
-       { LP8860_EEPROM_REG_6, 0x00 },
-       { LP8860_EEPROM_REG_7, 0x00 },
-       { LP8860_EEPROM_REG_8, 0x00 },
-       { LP8860_EEPROM_REG_9, 0x00 },
-       { LP8860_EEPROM_REG_10, 0x00 },
-       { LP8860_EEPROM_REG_11, 0x00 },
-       { LP8860_EEPROM_REG_12, 0x00 },
-       { LP8860_EEPROM_REG_13, 0x00 },
-       { LP8860_EEPROM_REG_14, 0x00 },
-       { LP8860_EEPROM_REG_15, 0x00 },
-       { LP8860_EEPROM_REG_16, 0x00 },
-       { LP8860_EEPROM_REG_17, 0x00 },
-       { LP8860_EEPROM_REG_18, 0x00 },
-       { LP8860_EEPROM_REG_19, 0x00 },
-       { LP8860_EEPROM_REG_20, 0x00 },
-       { LP8860_EEPROM_REG_21, 0x00 },
-       { LP8860_EEPROM_REG_22, 0x00 },
-       { LP8860_EEPROM_REG_23, 0x00 },
-       { LP8860_EEPROM_REG_24, 0x00 },
 };
 
 static const struct regmap_config lp8860_eeprom_regmap_config = {
@@ -354,8 +304,6 @@ static const struct regmap_config lp8860_eeprom_regmap_config = {
        .val_bits = 8,
 
        .max_register = LP8860_EEPROM_REG_24,
-       .reg_defaults = lp8860_eeprom_defs,
-       .num_reg_defaults = ARRAY_SIZE(lp8860_eeprom_defs),
 };
 
 static int lp8860_probe(struct i2c_client *client)