]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i3c: dw: Drop redundant Hot-Join cancel_work_sync() in shutdown
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 8 Jun 2026 05:43:09 +0000 (08:43 +0300)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 14 Jun 2026 19:40:10 +0000 (21:40 +0200)
The I3C core now installs an i3c_bus_type shutdown callback that
flushes master->hj_work (via i3c_master_shutdown()) before any driver's
platform shutdown hook runs. The explicit cancel_work_sync() in
dw_i3c_shutdown() is therefore redundant: by the time it executes, the
Hot-Join worker has already been cancelled, and the shutting_down gate
makes a new worker a no-op.

Remove the now-unneeded call. No functional change.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260608054312.10604-6-adrian.hunter@intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master/dw-i3c-master.c

index a60158331a8f5753cc723f8647a7b690fd56d573..971b429b76bc851137e83bf84d110daf82d9f179 100644 (file)
@@ -1812,8 +1812,6 @@ static void dw_i3c_shutdown(struct platform_device *pdev)
                return;
        }
 
-       cancel_work_sync(&master->base.hj_work);
-
        /* Disable interrupts */
        writel((u32)~INTR_ALL, master->regs + INTR_STATUS_EN);
        writel((u32)~INTR_ALL, master->regs + INTR_SIGNAL_EN);