]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: aspeed: Fix an IS_ERR() vs NULL bug in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 17 Oct 2025 16:04:34 +0000 (19:04 +0300)
committerMark Brown <broonie@kernel.org>
Fri, 17 Oct 2025 16:21:03 +0000 (17:21 +0100)
The platform_get_resource() function doesn't return error pointers, it
returns NULL on error.  Update the error checking to match.

Fixes: 64d87ccfae33 ("spi: aspeed: Only map necessary address window region")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aPJpEnfK31pHz8_w@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-aspeed-smc.c

index f3a7189afd51f9e5a468cbdd853df7ec59f52faa..e8bd8fe6c4e77da301932ce93e12e8430d0e377d 100644 (file)
@@ -865,9 +865,9 @@ static int aspeed_spi_probe(struct platform_device *pdev)
                return PTR_ERR(aspi->regs);
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-       if (IS_ERR(res)) {
+       if (!res) {
                dev_err(dev, "missing AHB memory\n");
-               return PTR_ERR(res);
+               return -EINVAL;
        }
 
        aspi->ahb_window_size = resource_size(res);