umount: more robust success message for --all

Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/sys-utils/umount.c b/sys-utils/umount.c
index fe120dbaa16011783ad97bf3747054bdb283d3f9..188a53adbcedfd6f02ef88484d551a917d6a54cd 100644 (file)
--- a/sys-utils/umount.c
+++ b/sys-utils/umount.c
@@ -281,10 +281,12 @@ static int umount_all(struct libmnt_context *cxt)
                        if (mnt_context_is_verbose(cxt))
                                printf(_("%-25s: ignored\n"), tgt);
                } else {
-                       rc |= mk_exit_code(cxt, mntrc);
+                       int xrc = mk_exit_code(cxt, mntrc);
 
-                       if (mnt_context_is_verbose(cxt))
+                       if (xrc == MOUNT_EX_SUCCESS
+                           && mnt_context_is_verbose(cxt))
                                printf("%-25s: successfully unmounted\n", tgt);
+                       rc |= xrc;
                }
        }