]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
conf/datadir: fix possible out of bounds array access
authorVictor Julien <victor@inliniac.net>
Fri, 17 Apr 2020 13:00:40 +0000 (15:00 +0200)
committerVictor Julien <victor@inliniac.net>
Mon, 20 Apr 2020 11:57:28 +0000 (13:57 +0200)
src/util-conf.c

index f36bfbf0889ba51934446ff70ea46b7751d14257..a5fc0e2c95653b743d75e8b65db7abc9197dc926 100644 (file)
@@ -74,7 +74,7 @@ TmEcode ConfigSetDataDirectory(char *name)
     size_t size = strlen(name) + 1;
     char tmp[size];
     strlcpy(tmp, name, size);
-    if (tmp[size - 2] == '/')
+    if (size > 2 && tmp[size - 2] == '/') // > 2 to allow just /
         tmp[size - 2] = '\0';
 
     return ConfSetFinal("default-data-dir", tmp) ? TM_ECODE_OK : TM_ECODE_FAILED;