raise Invalid_CPU_Number;
end if;
- Self_ID.Common.LL.Thread := pthread_self;
Self_ID.Common.LL.LWP := lwp_self;
-- Set thread name to ease debugging. If the name of the task is
-- do not need to manipulate caller's signal mask at this point.
-- All tasks in RTS will have All_Tasks_Mask initially.
- -- Note: the use of Unrestricted_Access in the following call is needed
- -- because otherwise we have an error of getting a access-to-volatile
- -- value which points to a non-volatile object. But in this case it is
- -- safe to do this, since we know we have no problems with aliasing and
- -- Unrestricted_Access bypasses this check.
+ -- The write to T.Common.LL.Thread is not racy with regard to the
+ -- created thread because the created thread will not access it until
+ -- we release the RTS lock (or the current task's lock when
+ -- Restricted.Stages is used). One can verify that by inspecting the
+ -- Task_Wrapper procedures.
Result := pthread_create
- (T.Common.LL.Thread'Unrestricted_Access,
+ (T.Common.LL.Thread'Access,
Thread_Attr'Access,
Thread_Body_Access (Wrapper),
To_Address (T));
begin
Environment_Task_Id := Environment_Task;
+ Environment_Task.Common.LL.Thread := pthread_self;
Interrupt_Management.Initialize;
procedure Enter_Task (Self_ID : Task_Id) is
begin
- Self_ID.Common.LL.Thread := pthread_self;
Self_ID.Common.LL.LWP := lwp_self;
Specific.Set (Self_ID);
-- do not need to manipulate caller's signal mask at this point.
-- All tasks in RTS will have All_Tasks_Mask initially.
- -- Note: the use of Unrestricted_Access in the following call is needed
- -- because otherwise we have an error of getting a access-to-volatile
- -- value which points to a non-volatile object. But in this case it is
- -- safe to do this, since we know we have no problems with aliasing and
- -- Unrestricted_Access bypasses this check.
+ -- The write to T.Common.LL.Thread is not racy with regard to the
+ -- created thread because the created thread will not access it until
+ -- we release the RTS lock (or the current task's lock when
+ -- Restricted.Stages is used). One can verify that by inspecting the
+ -- Task_Wrapper procedures.
Result := pthread_create
- (T.Common.LL.Thread'Unrestricted_Access,
+ (T.Common.LL.Thread'Access,
Attributes'Access,
Thread_Body_Access (Wrapper),
To_Address (T));
begin
Environment_Task_Id := Environment_Task;
+ Environment_Task.Common.LL.Thread := pthread_self;
Interrupt_Management.Initialize;
procedure Enter_Task (Self_ID : Task_Id) is
begin
- Self_ID.Common.LL.Thread := pthread_self;
Self_ID.Common.LL.LWP := lwp_self;
Specific.Set (Self_ID);
-- do not need to manipulate caller's signal mask at this point.
-- All tasks in RTS will have All_Tasks_Mask initially.
- -- Note: the use of Unrestricted_Access in the following call is needed
- -- because otherwise we have an error of getting a access-to-volatile
- -- value which points to a non-volatile object. But in this case it is
- -- safe to do this, since we know we have no problems with aliasing and
- -- Unrestricted_Access bypasses this check.
+ -- The write to T.Common.LL.Thread is not racy with regard to the
+ -- created thread because the created thread will not access it until
+ -- we release the RTS lock (or the current task's lock when
+ -- Restricted.Stages is used). One can verify that by inspecting the
+ -- Task_Wrapper procedures.
Result := pthread_create
- (T.Common.LL.Thread'Unrestricted_Access,
+ (T.Common.LL.Thread'Access,
Attributes'Access,
Thread_Body_Access (Wrapper),
To_Address (T));
begin
Environment_Task_Id := Environment_Task;
+ Environment_Task.Common.LL.Thread := pthread_self;
Interrupt_Management.Initialize;
procedure Enter_Task (Self_ID : Task_Id) is
begin
- Self_ID.Common.LL.Thread := pthread_self;
Self_ID.Common.LL.LWP := lwp_self;
Specific.Set (Self_ID);
-- do not need to manipulate caller's signal mask at this point.
-- All tasks in RTS will have All_Tasks_Mask initially.
- -- Note: the use of Unrestricted_Access in the following call is needed
- -- because otherwise we have an error of getting a access-to-volatile
- -- value which points to a non-volatile object. But in this case it is
- -- safe to do this, since we know we have no problems with aliasing and
- -- Unrestricted_Access bypasses this check.
+ -- The write to T.Common.LL.Thread is not racy with regard to the
+ -- created thread because the created thread will not access it until
+ -- we release the RTS lock (or the current task's lock when
+ -- Restricted.Stages is used). One can verify that by inspecting the
+ -- Task_Wrapper procedures.
Result := pthread_create
- (T.Common.LL.Thread'Unrestricted_Access,
+ (T.Common.LL.Thread'Access,
Attributes'Access,
Thread_Body_Access (Wrapper),
To_Address (T));
begin
Environment_Task_Id := Environment_Task;
+ Environment_Task.Common.LL.Thread := pthread_self;
Interrupt_Management.Initialize;
begin
Environment_Task_Id := Environment_Task;
+ Self_ID.Common.LL.Thread := thr_self;
Interrupt_Management.Initialize;
procedure Enter_Task (Self_ID : Task_Id) is
begin
- Self_ID.Common.LL.Thread := thr_self;
- Self_ID.Common.LL.LWP := lwp_self;
+ Self_ID.Common.LL.LWP := lwp_self;
Set_Task_Affinity (Self_ID);
Specific.Set (Self_ID);
Opts := THR_DETACHED + THR_BOUND;
end if;
- -- Note: the use of Unrestricted_Access in the following call is needed
- -- because otherwise we have an error of getting a access-to-volatile
- -- value which points to a non-volatile object. But in this case it is
- -- safe to do this, since we know we have no problems with aliasing and
- -- Unrestricted_Access bypasses this check.
+ -- The write to T.Common.LL.Thread is not racy with regard to the
+ -- created thread because the created thread will not access it until
+ -- we release the RTS lock (or the current task's lock when
+ -- Restricted.Stages is used). One can verify that by inspecting the
+ -- Task_Wrapper procedures.
Result :=
thr_create
Thread_Body_Access (Wrapper),
To_Address (T),
Opts,
- T.Common.LL.Thread'Unrestricted_Access);
+ T.Common.LL.Thread'Access);
Succeeded := Result = 0;
pragma Assert
type Private_Data is limited record
Thread : aliased System.OS_Interface.pthread_t;
- pragma Atomic (Thread);
- -- Thread field may be updated by two different threads of control.
- -- (See, Enter_Task and Create_Task in s-taprop.adb). They put the same
- -- value (thr_self value). We do not want to use lock on those
- -- operations and the only thing we have to make sure is that they are
- -- updated in atomic fashion.
+ -- This component is written to once before concurrent access to it is
+ -- possible, and then remains constant. The place where it is written to
+ -- depends on how the enclosing ATCB comes into existence:
+ --
+ -- 1. For the environment task, the component is set in
+ -- System.Task_Primitive.Operations.Initialize.
+ -- 2. For foreign threads, it happens in
+ -- System.Task_Primitives.Operations.Register_Foreign_Thread.
+ -- 3. For others tasks, it's in
+ -- System.Task_Primitives.Operations.Create_Task.
LWP : aliased System.OS_Interface.pthread_t;
-- The purpose of this field is to provide a better tasking support on
type Private_Data is limited record
Thread : aliased System.OS_Interface.pthread_t;
- pragma Atomic (Thread);
- -- Thread field may be updated by two different threads of control.
- -- (See, Enter_Task and Create_Task in s-taprop.adb). They put the same
- -- value (thr_self value). We do not want to use lock on those
- -- operations and the only thing we have to make sure is that they are
- -- updated in atomic fashion.
+ -- This component is written to once before concurrent access to it is
+ -- possible, and then remains constant. The place where it is written to
+ -- depends on how the enclosing ATCB comes into existence:
+ --
+ -- 1. For the environment task, the component is set in
+ -- System.Task_Primitive.Operations.Initialize.
+ -- 2. For foreign threads, it happens in
+ -- System.Task_Primitives.Operations.Register_Foreign_Thread.
+ -- 3. For others tasks, it's in
+ -- System.Task_Primitives.Operations.Create_Task.
LWP : aliased System.Address;
-- The purpose of this field is to provide a better tasking support on
type Private_Data is limited record
Thread : aliased System.OS_Interface.pthread_t;
- pragma Atomic (Thread);
- -- Thread field may be updated by two different threads of control.
- -- (See, Enter_Task and Create_Task in s-taprop.adb). They put the same
- -- value (thr_self value). We do not want to use lock on those
- -- operations and the only thing we have to make sure is that they are
- -- updated in atomic fashion.
+ -- This component is written to once before concurrent access to it is
+ -- possible, and then remains constant. The place where it is written to
+ -- depends on how the enclosing ATCB comes into existence:
+ --
+ -- 1. For the environment task, the component is set in
+ -- System.Task_Primitive.Operations.Initialize.
+ -- 2. For foreign threads, it happens in
+ -- System.Task_Primitives.Operations.Register_Foreign_Thread.
+ -- 3. For others tasks, it's in
+ -- System.Task_Primitives.Operations.Create_Task.
LWP : aliased System.Address;
-- The purpose of this field is to provide a better tasking support on
type Private_Data is limited record
Thread : aliased System.OS_Interface.thread_t;
- pragma Atomic (Thread);
- -- Thread field may be updated by two different threads of control.
- -- (See, Enter_Task and Create_Task in s-taprop.adb). They put the same
- -- value (thr_self value). We do not want to use lock on those
- -- operations and the only thing we have to make sure is that they are
- -- updated in atomic fashion.
+ -- This component is written to once before concurrent access to it is
+ -- possible, and then remains constant. The place where it is written to
+ -- depends on how the enclosing ATCB comes into existence:
+ --
+ -- 1. For the environment task, the component is set in
+ -- System.Task_Primitive.Operations.Initialize.
+ -- 2. For foreign threads, it happens in
+ -- System.Task_Primitives.Operations.Register_Foreign_Thread.
+ -- 3. For others tasks, it's in
+ -- System.Task_Primitives.Operations.Create_Task.
LWP : System.OS_Interface.lwpid_t;
-- The LWP id of the thread. Set by self in Enter_Task
Stack_Guard (Self_ID, True);
-- Initialize low-level TCB components, that cannot be initialized by
- -- the creator. Enter_Task sets Self_ID.LL.Thread.
+ -- the creator.
Enter_Task (Self_ID);
System.Soft_Links.Create_TSD
(Self_Id.Common.Compiler_Data, null, Sec_Stack_Size);
+ Self_Id.Common.LL.Thread := Thread;
Enter_Task (Self_Id);
return Self_Id;
projects / thirdparty / gcc.git / commitdiff
