]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: allow use of slot 0 in a dmi-to-pci-bridge
authorLaine Stump <laine@laine.org>
Wed, 2 Mar 2016 20:29:33 +0000 (15:29 -0500)
committerLaine Stump <laine@laine.org>
Thu, 14 Apr 2016 18:00:33 +0000 (14:00 -0400)
When support for dmi-to-pci-bridge was added, it was assumed that,
just as with the pci-root bus, slot 0 was reserved. This is not the
case - it can be used to connect a device just like any other slot, so
remove the restriction and update the test cases that auto-assign an
address on a dmi-to-pci-bridge.

28 files changed:
src/conf/domain_addr.c
tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args
tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args
tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-manual-addresses.args
tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port.args
tests/qemuxml2argvdata/qemuxml2argv-pcie-root.args
tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-downstream-port.args
tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-upstream-port.args
tests/qemuxml2argvdata/qemuxml2argv-pcihole64-q35.args
tests/qemuxml2argvdata/qemuxml2argv-q35-pm-disable-fallback.args
tests/qemuxml2argvdata/qemuxml2argv-q35-pm-disable.args
tests/qemuxml2argvdata/qemuxml2argv-q35-usb2-multi.args
tests/qemuxml2argvdata/qemuxml2argv-q35-usb2-reorder.args
tests/qemuxml2argvdata/qemuxml2argv-q35-usb2.args
tests/qemuxml2argvdata/qemuxml2argv-q35.args
tests/qemuxml2argvdata/qemuxml2argv-usb-controller-default-q35.args
tests/qemuxml2argvdata/qemuxml2argv-usb-controller-explicit-q35.args
tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-default.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-manual-addresses.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-root-port.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-root.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-switch-downstream-port.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-switch-upstream-port.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pcihole64-q35.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-usb2-multi.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-usb2-reorder.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-usb2.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-q35.xml

index 342c7aff407466c34f174e2018f4115c29e54b8e..722bf8e77c1a7b8e611cc28639219ec409f6e3e7 100644 (file)
@@ -190,10 +190,10 @@ virDomainPCIAddressBusSetModel(virDomainPCIAddressBusPtr bus,
         bus->maxSlot = VIR_PCI_ADDRESS_SLOT_LAST;
         break;
     case VIR_DOMAIN_CONTROLLER_MODEL_DMI_TO_PCI_BRIDGE:
-        /* slots 1 - 31, standard PCI slots,
+        /* slots 0 - 31, standard PCI slots,
          * but *not* hot-pluggable */
         bus->flags = VIR_PCI_CONNECT_TYPE_PCI;
-        bus->minSlot = 1;
+        bus->minSlot = 0;
         bus->maxSlot = VIR_PCI_ADDRESS_SLOT_LAST;
         break;
     case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT_PORT:
index 93c181db4c9ed0620722689ca3ea1b98aba3e80f..1163245aee3f2931b142ada5c3e5a9ea8014974e 100644 (file)
@@ -22,7 +22,7 @@ QEMU_AUDIO_DRV=none \
 -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \
 -dtb /aarch64.dtb \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1 \
--device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \
 -device virtio-serial-device,id=virtio-serial0 \
 -usb \
 -drive file=/aarch64.raw,format=raw,if=none,id=drive-virtio-disk0 \
index a7a996e2b0b5a35b893664322a70bfb8f2bbcb0d..9aaed4b70134217f59d03d10c4eca4fd13ea5602 100644 (file)
@@ -22,7 +22,7 @@ QEMU_AUDIO_DRV=none \
 -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \
 -dtb /aarch64.dtb \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1 \
--device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \
 -device virtio-serial-device,id=virtio-serial0 \
 -usb \
 -drive file=/aarch64.raw,format=raw,if=none,id=drive-virtio-disk0 \
index e3e962badb07dde6583416bbf3d855de47003a29..2dfcd1e3f809ccfe398d6def7cb7433a6b94fe06 100644 (file)
@@ -22,7 +22,7 @@ QEMU_AUDIO_DRV=none \
 -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \
 -dtb /aarch64.dtb \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1 \
--device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \
 -device virtio-scsi-pci,id=scsi0,bus=pcie.0,addr=0x3 \
 -usb \
 -drive file=/aarch64.raw,format=raw,if=none,id=drive-scsi0-0-0-0 \
index 7fd84f17ad2bf7d7e5def19b16114a0c7c91e2e1..8031ebc9eec5af17dfe75113dcfbe38396d6525c 100644 (file)
@@ -17,7 +17,7 @@ QEMU_AUDIO_DRV=none \
 -no-acpi \
 -boot c \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
--device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \
 -device ioh3420,port=0x10,chassis=3,id=pci.3,bus=pcie.0,addr=0x2 \
 -device ioh3420,port=0x1a,chassis=40,id=pci.4,bus=pcie.0,addr=0x3 \
 -drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-sata0-0-0 \
index 230d13cfe207f76c4fe3bc7f8872e7d0f4fcb44d..d6b139f3d7fc9fe5a745521fe473022d29405041 100644 (file)
@@ -17,4 +17,4 @@ QEMU_AUDIO_DRV=none \
 -no-acpi \
 -boot c \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
--device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x1
+-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0
index 9d55621cfaccf385156874a0784161e1fab11369..d94dc236448b899371eb39dcf90f2117b3af303e 100644 (file)
@@ -17,7 +17,7 @@ QEMU_AUDIO_DRV=none \
 -no-acpi \
 -boot c \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
--device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \
 -device ioh3420,port=0x10,chassis=3,id=pci.3,bus=pcie.0,addr=0x2 \
 -device x3130-upstream,id=pci.4,bus=pci.3,addr=0x0 \
 -device xio3130-downstream,port=0x0,chassis=5,id=pci.5,bus=pci.4,addr=0x0 \
index d8aa44b227a8707ed8e14b34bc03416c2539c3bc..ba2bba7925a17da1147d58c74debb582ffa90512 100644 (file)
@@ -17,7 +17,7 @@ QEMU_AUDIO_DRV=none \
 -no-acpi \
 -boot c \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
--device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \
 -device ioh3420,port=0x10,chassis=3,id=pci.3,bus=pcie.0,addr=0x2 \
 -device ioh3420,port=0x18,chassis=4,id=pci.4,bus=pcie.0,addr=0x3 \
 -device x3130-upstream,id=pci.5,bus=pci.3,addr=0x0 \
index b6ccda233b944eab50e990519d0ab18994767f3e..7d3a070a124f3cf3e9653ee03ac421845a2dbfa9 100644 (file)
@@ -18,7 +18,7 @@ QEMU_AUDIO_DRV=none \
 -boot c \
 -global q35-pcihost.pci-hole64-size=1048576K \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
--device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \
 -drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-sata0-0-0 \
 -device ide-drive,bus=ide.0,drive=drive-sata0-0-0,id=sata0-0-0 \
 -vga qxl \
index e439b499c363f7ecd098ed5e9c16329ee2dd1e83..c7eafc515c74242e98f45b7a38b0a8be995c4113 100644 (file)
@@ -19,5 +19,5 @@ QEMU_AUDIO_DRV=none \
 -global PIIX4_PM.disable_s4=1 \
 -boot n \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
--device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \
 -device virtio-balloon-pci,id=balloon0,bus=pci.2,addr=0x1
index 73cf9678b2e86cadd816edad8c488d02ffbe71a2..ec908517a3d83b81c6004db7f3a1419dfaba7ecd 100644 (file)
@@ -19,5 +19,5 @@ QEMU_AUDIO_DRV=none \
 -global ICH9-LPC.disable_s4=1 \
 -boot n \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
--device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \
 -device virtio-balloon-pci,id=balloon0,bus=pci.2,addr=0x1
index 26c4d3c34d2169c77d7ea7b172de11602df1f625..9da845b0c6ab600fd0a9062e88b68ec2efd330ce 100644 (file)
@@ -17,7 +17,7 @@ QEMU_AUDIO_DRV=none \
 -no-acpi \
 -boot c \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
--device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x0 \
 -device ich9-usb-ehci1,id=usb,bus=pcie.0,addr=0x1d.0x7 \
 -device ich9-usb-uhci1,masterbus=usb.0,firstport=0,bus=pcie.0,multifunction=on,\
 addr=0x1d \
index ba0e7fa841add62dac4831ea43d159a0a767d8de..bd0cd5561edc98de62f763a2db6d318877e955a6 100644 (file)
@@ -17,7 +17,7 @@ QEMU_AUDIO_DRV=none \
 -no-acpi \
 -boot c \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
--device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x0 \
 -device ich9-usb-ehci1,id=usb,bus=pcie.0,addr=0x1d.0x7 \
 -device ich9-usb-uhci1,masterbus=usb.0,firstport=0,bus=pcie.0,multifunction=on,\
 addr=0x1d \
index 98287e62a6491aadf88b91528caac355ea59358b..5cca714b69eff8202f47824281a65b922f132fce 100644 (file)
@@ -17,7 +17,7 @@ QEMU_AUDIO_DRV=none \
 -no-acpi \
 -boot c \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
--device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x0 \
 -device ich9-usb-ehci1,id=usb,bus=pcie.0,addr=0x1d.0x7 \
 -device ich9-usb-uhci1,masterbus=usb.0,firstport=0,bus=pcie.0,multifunction=on,\
 addr=0x1d \
index 98287e62a6491aadf88b91528caac355ea59358b..5cca714b69eff8202f47824281a65b922f132fce 100644 (file)
@@ -17,7 +17,7 @@ QEMU_AUDIO_DRV=none \
 -no-acpi \
 -boot c \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
--device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x0 \
 -device ich9-usb-ehci1,id=usb,bus=pcie.0,addr=0x1d.0x7 \
 -device ich9-usb-uhci1,masterbus=usb.0,firstport=0,bus=pcie.0,multifunction=on,\
 addr=0x1d \
index 8cfa37105d32c7a818804c749eb79a5961ad755f..7c33da2420a8bab9db3338c5460df181ed96bf32 100644 (file)
@@ -16,6 +16,6 @@ QEMU_AUDIO_DRV=none \
 -monitor unix:/tmp/lib/domain--1-q35-test/monitor.sock,server,nowait \
 -no-acpi \
 -boot c \
--device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x0 \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
 -device piix3-usb-uhci,id=usb,bus=pcie.0,addr=0x1
index 020f1590ac17de0c61674156f0cdc3e2f92d4cd9..d24f9cdb5eb2d21cdd0716c69969e97926040413 100644 (file)
@@ -16,6 +16,6 @@ QEMU_AUDIO_DRV=none \
 -monitor unix:/tmp/lib/domain--1-q35-test/monitor.sock,server,nowait \
 -no-acpi \
 -boot c \
--device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x1 \
+-device pci-bridge,chassis_nr=56,id=pci.2,bus=pci.1,addr=0x0 \
 -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
 -device nec-usb-xhci,id=usb,bus=pcie.0,addr=0x1
index 415d041a39fc66c72feb3a807d3b8f5f51242af7..be2e113d2cf4651fb99a6209a6c256ac4e2a3ac8 100644 (file)
@@ -40,7 +40,7 @@
     <controller type='pci' index='2' model='pci-bridge'>
       <model name='pci-bridge'/>
       <target chassisNr='2'/>
-      <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
     </controller>
     <controller type='virtio-serial' index='0'>
       <address type='virtio-mmio'/>
index 0ee40f5eaad47eb23e507305ab1a9fda1a08107f..0d691691574e979526df6f326480754533a45be2 100644 (file)
@@ -43,7 +43,7 @@
     <controller type='pci' index='2' model='pci-bridge'>
       <model name='pci-bridge'/>
       <target chassisNr='2'/>
-      <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
     </controller>
     <interface type='user'>
       <mac address='52:54:00:09:a4:37'/>
index ea61bcf2007e0e5b90fd82a523ccca2cd417ad22..a4ff820d940e3741f45a87b64b73318e8a0bf3cc 100644 (file)
@@ -27,7 +27,7 @@
     <controller type='pci' index='2' model='pci-bridge'>
       <model name='pci-bridge'/>
       <target chassisNr='2'/>
-      <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
     </controller>
     <controller type='pci' index='3' model='pcie-root-port'>
       <model name='ioh3420'/>
index 013cbc44f900e000d4e707e5748ce7bc1ee22fb8..7f2e21a45561ed4b809a0ab281fa537d0c55b2d2 100644 (file)
@@ -25,7 +25,7 @@
     <controller type='pci' index='2' model='pci-bridge'>
       <model name='pci-bridge'/>
       <target chassisNr='2'/>
-      <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
     </controller>
     <input type='mouse' bus='ps2'/>
     <input type='keyboard' bus='ps2'/>
index 22cfeaa8741509b01e9a5a11189b7779513794fb..beb6ca8cf0359409eb58fbd5ac5f61b61d84c264 100644 (file)
@@ -27,7 +27,7 @@
     <controller type='pci' index='2' model='pci-bridge'>
       <model name='pci-bridge'/>
       <target chassisNr='2'/>
-      <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
     </controller>
     <controller type='pci' index='3' model='pcie-root-port'>
       <model name='ioh3420'/>
index 813ba97487b42e22a49c03eae5f4cd9d1e70912f..53e10d0c70cc05959e544739b36cd9b7711dcdc8 100644 (file)
@@ -27,7 +27,7 @@
     <controller type='pci' index='2' model='pci-bridge'>
       <model name='pci-bridge'/>
       <target chassisNr='2'/>
-      <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
     </controller>
     <controller type='pci' index='3' model='pcie-root-port'>
       <model name='ioh3420'/>
index 7e9a36690e583b50171225d056bb2f1ca977ca46..dad7d1a4fbb3076f1afd3bca03ce07ddf4dd4c90 100644 (file)
@@ -29,7 +29,7 @@
     <controller type='pci' index='2' model='pci-bridge'>
       <model name='pci-bridge'/>
       <target chassisNr='2'/>
-      <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
     </controller>
     <controller type='sata' index='0'>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x1f' function='0x2'/>
index 35e8fed43b97b0f6bd4aae5874e9e31ab6b67c80..06c0699ee547faddac883b555b0633213c02294f 100644 (file)
@@ -27,7 +27,7 @@
     <controller type='pci' index='2' model='pci-bridge'>
       <model name='pci-bridge'/>
       <target chassisNr='56'/>
-      <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
     </controller>
     <controller type='usb' index='0' model='ich9-ehci1'>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x1d' function='0x7'/>
index 914c7f8354e1a09bd9dcea67f805c06b8031162c..100709577de1ec4ad63f1a4ae545fdf31af7dfb0 100644 (file)
@@ -27,7 +27,7 @@
     <controller type='pci' index='2' model='pci-bridge'>
       <model name='pci-bridge'/>
       <target chassisNr='56'/>
-      <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
     </controller>
     <controller type='usb' index='0' model='ich9-ehci1'>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x1d' function='0x7'/>
index 3fd2c0e9afe3ce356c2e94927c61614bc0524e9f..58c7fab396b5eb1565e3645eac1c887b90991214 100644 (file)
@@ -27,7 +27,7 @@
     <controller type='pci' index='2' model='pci-bridge'>
       <model name='pci-bridge'/>
       <target chassisNr='56'/>
-      <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
     </controller>
     <controller type='usb' index='0' model='ich9-ehci1'>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x1d' function='0x7'/>
index 3fd2c0e9afe3ce356c2e94927c61614bc0524e9f..58c7fab396b5eb1565e3645eac1c887b90991214 100644 (file)
@@ -27,7 +27,7 @@
     <controller type='pci' index='2' model='pci-bridge'>
       <model name='pci-bridge'/>
       <target chassisNr='56'/>
-      <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
     </controller>
     <controller type='usb' index='0' model='ich9-ehci1'>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x1d' function='0x7'/>