]> git.ipfire.org Git - thirdparty/tornado.git/commitdiff
Change "except Type, value" to "except Type as value".
authorBen Darnell <ben@bendarnell.com>
Mon, 14 Jan 2013 00:16:33 +0000 (19:16 -0500)
committerBen Darnell <ben@bendarnell.com>
Mon, 14 Jan 2013 00:16:33 +0000 (19:16 -0500)
Necessary for py3, supported since py26.
2to3 -n -w -f except tornado

20 files changed:
tornado/autoreload.py
tornado/concurrent.py
tornado/curl_httpclient.py
tornado/httpclient.py
tornado/httpserver.py
tornado/ioloop.py
tornado/iostream.py
tornado/locale.py
tornado/log.py
tornado/netutil.py
tornado/platform/common.py
tornado/process.py
tornado/test/concurrent_test.py
tornado/test/ioloop_test.py
tornado/test/process_test.py
tornado/test/simple_httpclient_test.py
tornado/test/util_test.py
tornado/test/web_test.py
tornado/testing.py
tornado/web.py

index 62af0f3b05f32fae0be05318d11f43db47279e05..e7c5d481a55f525114bbd605394dcd877603e004 100644 (file)
@@ -278,10 +278,10 @@ def main():
                 # something that tries to import __main__ (e.g. the unittest
                 # module) will see the right things.
                 exec f.read() in globals(), globals()
-    except SystemExit, e:
+    except SystemExit as e:
         logging.basicConfig()
         gen_log.info("Script exited with status %s", e.code)
-    except Exception, e:
+    except Exception as e:
         logging.basicConfig()
         gen_log.warning("Script exited with uncaught exception", exc_info=True)
         # If an exception occurred at import time, the file with the error
index 80596844db3161ce00f28706bc6d7c2c2b22b330..c1a9593c2fa45491aec9b161cc8e4f7062db5635 100644 (file)
@@ -94,7 +94,7 @@ class DummyExecutor(object):
         future = Future()
         try:
             future.set_result(fn(*args, **kwargs))
-        except Exception, e:
+        except Exception as e:
             future.set_exception(e)
         return future
 
index 52350d246625d0fe0438bb3767979344d28c57bc..ebf54ae9f96c5322896b4032bb60e59577b1d0e4 100644 (file)
@@ -128,7 +128,7 @@ class CurlAsyncHTTPClient(AsyncHTTPClient):
         while True:
             try:
                 ret, num_handles = self._socket_action(fd, action)
-            except pycurl.error, e:
+            except pycurl.error as e:
                 ret = e.args[0]
             if ret != pycurl.E_CALL_MULTI_PERFORM:
                 break
@@ -142,7 +142,7 @@ class CurlAsyncHTTPClient(AsyncHTTPClient):
                 try:
                     ret, num_handles = self._socket_action(
                         pycurl.SOCKET_TIMEOUT, 0)
-                except pycurl.error, e:
+                except pycurl.error as e:
                     ret = e.args[0]
                 if ret != pycurl.E_CALL_MULTI_PERFORM:
                     break
@@ -173,7 +173,7 @@ class CurlAsyncHTTPClient(AsyncHTTPClient):
             while True:
                 try:
                     ret, num_handles = self._multi.socket_all()
-                except pycurl.error, e:
+                except pycurl.error as e:
                     ret = e.args[0]
                 if ret != pycurl.E_CALL_MULTI_PERFORM:
                     break
index 7359a76cefb05591ace17beadf3abe0a7ba207bf..dadb4d440e72f75084a827787ea01d565bc88169 100644 (file)
@@ -440,7 +440,7 @@ def main():
                                     follow_redirects=options.follow_redirects,
                                     validate_cert=options.validate_cert,
                                     )
-        except HTTPError, e:
+        except HTTPError as e:
             if e.response is not None:
                 response = e.response
             else:
index af441d93061235c6d8a813793990036525bdcf6c..47120ca596defc1666a5a29ca0dabcf463a8787d 100644 (file)
@@ -283,7 +283,7 @@ class HTTPConnection(object):
                 return
 
             self.request_callback(self._request)
-        except _BadRequestException, e:
+        except _BadRequestException as e:
             gen_log.info("Malformed HTTP request from %s: %s",
                          self.address[0], e)
             self.close()
@@ -484,7 +484,7 @@ class HTTPRequest(object):
                                      socket.SOCK_STREAM,
                                      0, socket.AI_NUMERICHOST)
             return bool(res)
-        except socket.gaierror, e:
+        except socket.gaierror as e:
             if e.args[0] == socket.EAI_NONAME:
                 return False
             raise
index 5e42147e4dea66c7bf32656405fad1e9eb36aaf0..ef44decc6cc6615fbcfed57fda61433a69f631f3 100644 (file)
@@ -543,7 +543,7 @@ class PollIOLoop(IOLoop):
 
             try:
                 event_pairs = self._impl.poll(poll_timeout)
-            except Exception, e:
+            except Exception as e:
                 # Depending on python version and IOLoop implementation,
                 # different exception types may be thrown and there are
                 # two ways EINTR might be signaled:
@@ -569,7 +569,7 @@ class PollIOLoop(IOLoop):
                 fd, events = self._events.popitem()
                 try:
                     self._handlers[fd](fd, events)
-                except (OSError, IOError), e:
+                except (OSError, IOError) as e:
                     if e.args[0] == errno.EPIPE:
                         # Happens when the client closes the connection
                         pass
index 6eec2a357429fe536aeb44977c67ae1da508c31c..f090bc6dda92e8311ac77f9076554bb754617807 100644 (file)
@@ -399,7 +399,7 @@ class BaseIOStream(object):
         """
         try:
             chunk = self.read_from_fd()
-        except (socket.error, IOError, OSError), e:
+        except (socket.error, IOError, OSError) as e:
             # ssl.SSLError is a subclass of socket.error
             if e.args[0] == errno.ECONNRESET:
                 # Treat ECONNRESET as a connection close rather than
@@ -504,7 +504,7 @@ class BaseIOStream(object):
                 self._write_buffer_frozen = False
                 _merge_prefix(self._write_buffer, num_bytes)
                 self._write_buffer.popleft()
-            except socket.error, e:
+            except socket.error as e:
                 if e.args[0] in (errno.EWOULDBLOCK, errno.EAGAIN):
                     self._write_buffer_frozen = True
                     break
@@ -630,7 +630,7 @@ class IOStream(BaseIOStream):
     def read_from_fd(self):
         try:
             chunk = self.socket.recv(self.read_chunk_size)
-        except socket.error, e:
+        except socket.error as e:
             if e.args[0] in (errno.EWOULDBLOCK, errno.EAGAIN):
                 return None
             else:
@@ -661,7 +661,7 @@ class IOStream(BaseIOStream):
         self._connecting = True
         try:
             self.socket.connect(address)
-        except socket.error, e:
+        except socket.error as e:
             # In non-blocking mode we expect connect() to raise an
             # exception with EINPROGRESS or EWOULDBLOCK.
             #
@@ -732,7 +732,7 @@ class SSLIOStream(IOStream):
             self._handshake_reading = False
             self._handshake_writing = False
             self.socket.do_handshake()
-        except ssl.SSLError, err:
+        except ssl.SSLError as err:
             if err.args[0] == ssl.SSL_ERROR_WANT_READ:
                 self._handshake_reading = True
                 return
@@ -751,7 +751,7 @@ class SSLIOStream(IOStream):
                                 self.socket.fileno(), peer, err)
                 return self.close(exc_info=True)
             raise
-        except socket.error, err:
+        except socket.error as err:
             if err.args[0] in (errno.ECONNABORTED, errno.ECONNRESET):
                 return self.close(exc_info=True)
         else:
@@ -804,14 +804,14 @@ class SSLIOStream(IOStream):
             # called when there is nothing to read, so we have to use
             # read() instead.
             chunk = self.socket.read(self.read_chunk_size)
-        except ssl.SSLError, e:
+        except ssl.SSLError as e:
             # SSLError is a subclass of socket.error, so this except
             # block must come first.
             if e.args[0] == ssl.SSL_ERROR_WANT_READ:
                 return None
             else:
                 raise
-        except socket.error, e:
+        except socket.error as e:
             if e.args[0] in (errno.EWOULDBLOCK, errno.EAGAIN):
                 return None
             else:
@@ -844,7 +844,7 @@ class PipeIOStream(BaseIOStream):
     def read_from_fd(self):
         try:
             chunk = os.read(self.fd, self.read_chunk_size)
-        except (IOError, OSError), e:
+        except (IOError, OSError) as e:
             if e.args[0] in (errno.EWOULDBLOCK, errno.EAGAIN):
                 return None
             elif e.args[0] == errno.EBADF:
index c5d49db653633913b9f4351198c83626969b5f22..e44875b301d8777c20966905e07d215a626cc5fb 100644 (file)
@@ -184,7 +184,7 @@ def load_gettext_translations(directory, domain):
             os.stat(os.path.join(directory, lang, "LC_MESSAGES", domain + ".mo"))
             _translations[lang] = gettext.translation(domain, directory,
                                                       languages=[lang])
-        except Exception, e:
+        except Exception as e:
             gen_log.error("Cannot load translation for '%s': %s", lang, str(e))
             continue
     _supported_locales = frozenset(_translations.keys() + [_default_locale])
index 72433536b74205450a9d1f6aedce3d408f8853c9..f7b74fe95b2ffb81d8a942b8fca05891b02c4e8b 100644 (file)
@@ -102,7 +102,7 @@ class LogFormatter(logging.Formatter):
     def format(self, record):
         try:
             record.message = record.getMessage()
-        except Exception, e:
+        except Exception as e:
             record.message = "Bad message (%r): %r" % (e, record.__dict__)
         assert isinstance(record.message, basestring)  # guaranteed by logging
         record.asctime = time.strftime(
index 291dbecd9201dc61e30ed79813c8e7578c339765..0375cab3ab4334ec748a97a54c406b87d5f0a1f5 100644 (file)
@@ -218,12 +218,12 @@ class TCPServer(object):
                                              server_side=True,
                                              do_handshake_on_connect=False,
                                              **self.ssl_options)
-            except ssl.SSLError, err:
+            except ssl.SSLError as err:
                 if err.args[0] == ssl.SSL_ERROR_EOF:
                     return connection.close()
                 else:
                     raise
-            except socket.error, err:
+            except socket.error as err:
                 if err.args[0] == errno.ECONNABORTED:
                     return connection.close()
                 else:
@@ -304,7 +304,7 @@ if hasattr(socket, 'AF_UNIX'):
         sock.setblocking(0)
         try:
             st = os.stat(file)
-        except OSError, err:
+        except OSError as err:
             if err.errno != errno.ENOENT:
                 raise
         else:
@@ -334,7 +334,7 @@ def add_accept_handler(sock, callback, io_loop=None):
         while True:
             try:
                 connection, address = sock.accept()
-            except socket.error, e:
+            except socket.error as e:
                 if e.args[0] in (errno.EWOULDBLOCK, errno.EAGAIN):
                     return
                 raise
index 39f60bd7989bc244911ef5aaf133a69df5a8b12f..a01f3789ec4cf1f5c2f887baac826623fe79eab6 100644 (file)
@@ -43,7 +43,7 @@ class Waker(interface.Waker):
             try:
                 self.writer.connect(connect_address)
                 break    # success
-            except socket.error, detail:
+            except socket.error as detail:
                 if (not hasattr(errno, 'WSAEADDRINUSE') or
                     detail[0] != errno.WSAEADDRINUSE):
                     # "Address already in use" is the only error
index fa0be555f0dbeeea574d3c049d0c3f041af8567f..f8f532ce41f2caa0313d01f9755cf9b3a29bbc41 100644 (file)
@@ -125,7 +125,7 @@ def fork_processes(num_processes, max_restarts=100):
     while children:
         try:
             pid, status = os.wait()
-        except OSError, e:
+        except OSError as e:
             if e.errno == errno.EINTR:
                 continue
             raise
@@ -260,7 +260,7 @@ class Subprocess(object):
     def _try_cleanup_process(cls, pid):
         try:
             ret_pid, status = os.waitpid(pid, os.WNOHANG)
-        except OSError, e:
+        except OSError as e:
             if e.args[0] == errno.ECHILD:
                 return
         if ret_pid == 0:
index 5267358ad1ffd45a0bd19222c7670a3e08c3bc0a..a33f4a580e240491703e9c140de7a599aceb7889 100644 (file)
@@ -83,7 +83,7 @@ class ManualCapClient(BaseCapClient):
         self.stream.close()
         try:
             self.future.set_result(self.process_response(data))
-        except CapError, e:
+        except CapError as e:
             self.future.set_exception(e)
 
 
index 53bb8a4491290a10466260d37583ee505c3f1a25..d3efb44242bb2f9fad854c0f8eefd54fe59fde99 100644 (file)
@@ -110,7 +110,7 @@ class TestIOLoop(AsyncTestCase):
         for i in range(1000):
             try:
                 other_ioloop.add_callback(lambda: None)
-            except RuntimeError, e:
+            except RuntimeError as e:
                 self.assertEqual("IOLoop is closing", str(e))
                 break
 
index 43748ebc9ebac4d4b20a9508c2257d7473a693a7..2ea33841cadcfc93b614d27e48c8f029dfad7586 100644 (file)
@@ -69,7 +69,7 @@ class ProcessTest(unittest.TestCase):
                 id = fork_processes(3, max_restarts=3)
                 self.assertTrue(id is not None)
                 signal.alarm(5)  # child processes
-            except SystemExit, e:
+            except SystemExit as e:
                 # if we exit cleanly from fork_processes, all the child processes
                 # finished with status 0
                 self.assertEqual(e.code, 0)
@@ -94,7 +94,7 @@ class ProcessTest(unittest.TestCase):
                     def fetch(url, fail_ok=False):
                         try:
                             return client.fetch(get_url(url))
-                        except HTTPError, e:
+                        except HTTPError as e:
                             if not (fail_ok and e.code == 599):
                                 raise
 
index e0e6d376b5c9df6aefbd91b894aabb66eda9f31a..66faed1e493987f4ad8eb85e7921c00fa9cd9761 100644 (file)
@@ -223,7 +223,7 @@ class SimpleHTTPClientTestCase(AsyncHTTPTestCase):
     def test_ipv6(self):
         try:
             self.http_server.listen(self.get_http_port(), address='::1')
-        except socket.gaierror, e:
+        except socket.gaierror as e:
             if e.args[0] == socket.EAI_ADDRFAMILY:
                 # python supports ipv6, but it's not configured on the network
                 # interface, so skip this test.
index aa1bf09bf09f7cf7ed935834f7453605562f5a98..068f8d9f3ce966d36be46255cbd376c6a4127b0d 100644 (file)
@@ -24,7 +24,7 @@ class RaiseExcInfoTest(unittest.TestCase):
         try:
             raise_exc_info(exc_info)
             self.fail("didn't get expected exception")
-        except TwoArgException, e:
+        except TwoArgException as e:
             self.assertIs(e, exc_info[1])
 
 class TestConfigurable(Configurable):
index cb370296cc0a68ddba74d82d81cc4d3b1ae0b338..255a85b1ba9e09540bf8a2bb8804ace8a450e905 100644 (file)
@@ -460,7 +460,7 @@ class HeaderInjectionHandler(RequestHandler):
         try:
             self.set_header("X-Foo", "foo\r\nX-Bar: baz")
             raise Exception("Didn't get expected exception")
-        except ValueError, e:
+        except ValueError as e:
             if "Unsafe header value" in str(e):
                 self.finish(b("ok"))
             else:
index 22376627e58903fb958c777547b008d978ecd58f..bca68999d419d9d24793f79c0f850b1e059eab44 100644 (file)
@@ -509,7 +509,7 @@ def main(**kwargs):
             unittest.main(module=None, argv=argv, **kwargs)
         else:
             unittest.main(defaultTest="all", argv=argv, **kwargs)
-    except SystemExit, e:
+    except SystemExit as e:
         if e.code == 0:
             gen_log.info('PASS')
         else:
index 41ce95d4b8802097b5f9fa5a994380e9c9ef2041..446a330c2557fcc050e08098bea591cc0e266710 100644 (file)
@@ -1007,7 +1007,7 @@ class RequestHandler(object):
         def wrapper(*args, **kwargs):
             try:
                 return callback(*args, **kwargs)
-            except Exception, e:
+            except Exception as e:
                 if self._headers_written:
                     app_log.error("Exception after headers written",
                                   exc_info=True)
@@ -1067,7 +1067,7 @@ class RequestHandler(object):
                     *self.path_args, **self.path_kwargs)
                 if self._auto_finish and not self._finished:
                     self.finish()
-        except Exception, e:
+        except Exception as e:
             self._handle_request_exception(e)
 
     def _generate_headers(self):