]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
portabled-bus: use CLEANUP_ARRAY
authorDavid Tardon <dtardon@redhat.com>
Tue, 28 Mar 2023 11:33:48 +0000 (13:33 +0200)
committerDavid Tardon <dtardon@redhat.com>
Tue, 11 Apr 2023 14:32:45 +0000 (16:32 +0200)
src/portable/portabled-bus.c

index 768964231a16e99494b40fff2cca6fd1ac1265a8..0d5518060eb9a9276ac2243b247d06cf63bc9216 100644 (file)
@@ -281,6 +281,8 @@ static int method_detach_image(sd_bus_message *message, void *userdata, sd_bus_e
 
         assert(message);
 
+        CLEANUP_ARRAY(changes, n_changes, portable_changes_free);
+
         /* Note that we do not redirect detaching to the image object here, because we want to allow that users can
          * detach already deleted images too, in case the user already deleted an image before properly detaching
          * it. */
@@ -339,13 +341,9 @@ static int method_detach_image(sd_bus_message *message, void *userdata, sd_bus_e
                         &n_changes,
                         error);
         if (r < 0)
-                goto finish;
-
-        r = reply_portable_changes(message, changes, n_changes);
+                return r;
 
-finish:
-        portable_changes_free(changes, n_changes);
-        return r;
+        return reply_portable_changes(message, changes, n_changes);
 }
 
 static int method_reattach_image(sd_bus_message *message, void *userdata, sd_bus_error *error) {