]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
flowbits: optimize set and remove
authorVictor Julien <victor@inliniac.net>
Wed, 24 Feb 2016 09:50:06 +0000 (10:50 +0100)
committerVictor Julien <victor@inliniac.net>
Wed, 24 Feb 2016 13:00:11 +0000 (14:00 +0100)
src/flow-bit.c

index 2e52b9ef1aa0052bc8cfbdec19eb20633dfa734e..934d485996cc5a6d8de019a30189a1f569fe5ca7 100644 (file)
@@ -105,31 +105,25 @@ static void FlowBitRemove(Flow *f, uint16_t idx)
 
 void FlowBitSetNoLock(Flow *f, uint16_t idx)
 {
-    FlowBit *fb = FlowBitGet(f, idx);
-    if (fb == NULL) {
-        FlowBitAdd(f, idx);
-    }
+    FlowBitAdd(f, idx);
 }
 
 void FlowBitSet(Flow *f, uint16_t idx)
 {
     FLOWLOCK_WRLOCK(f);
-    FlowBitSetNoLock(f, idx);
+    FlowBitAdd(f, idx);
     FLOWLOCK_UNLOCK(f);
 }
 
 void FlowBitUnsetNoLock(Flow *f, uint16_t idx)
 {
-    FlowBit *fb = FlowBitGet(f, idx);
-    if (fb != NULL) {
-        FlowBitRemove(f, idx);
-    }
+    FlowBitRemove(f, idx);
 }
 
 void FlowBitUnset(Flow *f, uint16_t idx)
 {
     FLOWLOCK_WRLOCK(f);
-    FlowBitUnsetNoLock(f, idx);
+    FlowBitRemove(f, idx);
     FLOWLOCK_UNLOCK(f);
 }