[rt46602] Clean up getopts usage

Ensure case clauses are in sync with the string passed to getopts.
Remove catch-all clauses as they will never be evaluated.

diff --git a/bin/tests/system/clean.sh b/bin/tests/system/clean.sh
index 84c369e0af53dbee47371ae5b735dba546719ac5..a53724917c29513d2488a377edb40f53766f17e6 100644 (file)
--- a/bin/tests/system/clean.sh
+++ b/bin/tests/system/clean.sh
@@ -24,7 +24,6 @@ runall=0
 while getopts "r" flag; do
     case $flag in
        r) runall=1 ;;
-       *) exit 1;;
     esac
 done
 shift `expr $OPTIND - 1`

diff --git a/bin/tests/system/run.sh b/bin/tests/system/run.sh
index 549313bf508e5b175a2dbe3350c918c2df9e9be3..9a7e472a42bd4c8f78d8a97b3b32fc8c3d1f1a5d 100644 (file)
--- a/bin/tests/system/run.sh
+++ b/bin/tests/system/run.sh
@@ -17,13 +17,12 @@ stopservers=true
 clean=true
 baseport=5300
 
-while getopts "rnp:d:" flag; do
+while getopts "knp:r" flag; do
     case "$flag" in
        k) stopservers=false ;;
        n) clean=false ;;
        p) baseport=$OPTARG ;;
        r) runall="-r" ;;
-       *) exit 1 ;;
     esac
 done
 shift `expr $OPTIND - 1`

diff --git a/bin/tests/system/runall.sh b/bin/tests/system/runall.sh
index c28296dad7a4bd47f44628ecfabdd32a55d349c6..54da64ea52a102c31414bfa03b32e6fa1a7a1533 100644 (file)
--- a/bin/tests/system/runall.sh
+++ b/bin/tests/system/runall.sh
@@ -25,7 +25,6 @@ usage="Usage: ./runall.sh [-n] [numprocesses]"
 while getopts "n" flag; do
     case "$flag" in
        n) CLEANFLAG="NOCLEAN=-n" ;;
-       *) echo "$usage" >&2 ; exit 1 ;;
     esac
 done
 shift `expr $OPTIND - 1`

diff --git a/bin/tests/system/testsummary.sh b/bin/tests/system/testsummary.sh
index 45beed8ab2680209da4b6f47308bbe32e1dcf563..8b046b61cbc548f29391b85c7e99e3d4b4e4bbf4 100644 (file)
--- a/bin/tests/system/testsummary.sh
+++ b/bin/tests/system/testsummary.sh
@@ -29,7 +29,6 @@ keepfile=0
 while getopts "n" flag; do
     case $flag in
        n) keepfile=1 ;;
-       *) exit 1 ;;
     esac
 done