]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: adnp: use devm_mutex_init()
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 3 Mar 2025 13:18:28 +0000 (14:18 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 10 Mar 2025 10:52:12 +0000 (11:52 +0100)
The mutex initialized in probe() is never cleaned up. Use
devm_mutex_init() to do it automatically.

Link: https://lore.kernel.org/r/20250303-gpiochip-set-conversion-v1-3-1d5cceeebf8b@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-adnp.c

index 6dafab0cf964ed6250d4d956b150daec20ff7d16..9e752e98db9d563678ce349eb0d775d55a226c7e 100644 (file)
@@ -8,6 +8,7 @@
 #include <linux/interrupt.h>
 #include <linux/mod_devicetable.h>
 #include <linux/module.h>
+#include <linux/mutex.h>
 #include <linux/property.h>
 #include <linux/seq_file.h>
 #include <linux/slab.h>
@@ -506,7 +507,10 @@ static int adnp_i2c_probe(struct i2c_client *client)
        if (!adnp)
                return -ENOMEM;
 
-       mutex_init(&adnp->i2c_lock);
+       err = devm_mutex_init(&client->dev, &adnp->i2c_lock);
+       if (err)
+               return err;
+
        adnp->client = client;
 
        err = adnp_gpio_setup(adnp, num_gpios, device_property_read_bool(dev, "interrupt-controller"));