]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: ov01a10: Add missing v4l2_subdev_cleanup() calls
authorHans de Goede <hansg@kernel.org>
Tue, 14 Oct 2025 17:40:12 +0000 (19:40 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 13 Jan 2026 11:28:48 +0000 (12:28 +0100)
Add missing v4l2_subdev_cleanup() calls to cleanup after
v4l2_subdev_init_finalize().

Fixes: 0827b58dabff ("media: i2c: add ov01a10 image sensor driver")
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hansg@kernel.org>
Tested-by: Mehdi Djait <mehdi.djait@linux.intel.com> # Dell XPS 9315
Reviewed-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov01a10.c

index 834ca46acb75fe1a2bf130615480d8fe53b9e88e..1e22df12989aee30eeaca3c29a154054dc26c568 100644 (file)
@@ -864,6 +864,7 @@ static void ov01a10_remove(struct i2c_client *client)
        struct v4l2_subdev *sd = i2c_get_clientdata(client);
 
        v4l2_async_unregister_subdev(sd);
+       v4l2_subdev_cleanup(sd);
        media_entity_cleanup(&sd->entity);
        v4l2_ctrl_handler_free(sd->ctrl_handler);
 
@@ -934,6 +935,7 @@ static int ov01a10_probe(struct i2c_client *client)
 err_pm_disable:
        pm_runtime_disable(dev);
        pm_runtime_set_suspended(&client->dev);
+       v4l2_subdev_cleanup(&ov01a10->sd);
 
 err_media_entity_cleanup:
        media_entity_cleanup(&ov01a10->sd.entity);