[ng] maintcheck: fix some failures

* tests/cscope.tap: Don't use 'using_gmake', simply assume we are
indeed using GNU make.
* tests/yacc-nodist.test: Likewise.
* tests/yacc-bison-skeleton.test: Don't use "make -e".
* tests/yacc-bison-skeleton-cxx.test: Likewise.

diff --git a/tests/cscope.tap b/tests/cscope.tap
index 36adeca75fda750f4501be7a8e5790aac6ac85e1..806912aa36dcbc5ae01caf244addd087a1883374 100755 (executable)
--- a/tests/cscope.tap
+++ b/tests/cscope.tap
@@ -135,29 +135,21 @@ my_configure ()
               "$1"/configure EMACS=no --with-lispdir=/who/cares
 }
 
-if using_gmake; then
-
-  cd "$ocwd"
-  pfx="relative VPATH"
-  mkdir build
-  cd build
-  my_configure ..
-  test_cscope
-  test_cleanup
-
-  cd "$ocwd"
-  pfx="absolute VPATH"
-  mkdir build2
-  cd build2
-  my_configure "$ocwd"
-  test_cscope
-  test_cleanup
-
-else
-
-  skip_row_ 12 -r "cscope in VPATH required GNU make"
+cd "$ocwd"
+pfx="relative VPATH"
+mkdir build
+cd build
+my_configure ..
+test_cscope
+test_cleanup
 
-fi
+cd "$ocwd"
+pfx="absolute VPATH"
+mkdir build2
+cd build2
+my_configure "$ocwd"
+test_cscope
+test_cleanup
 
 cd "$ocwd"
 pfx="in-tree build"

diff --git a/tests/yacc-bison-skeleton-cxx.test b/tests/yacc-bison-skeleton-cxx.test
index 0d3c99b8ade922244751b58e4bb563e7ea6fcdb2..ee5cb88d13b69337a6e8d267e480ff2858305ea6 100755 (executable)
--- a/tests/yacc-bison-skeleton-cxx.test
+++ b/tests/yacc-bison-skeleton-cxx.test
@@ -95,6 +95,6 @@ $MAKE
 
 # Check that distribution is self-contained, and do not require
 # bison to be built.
-env YACC=false DISTCHECK_CONFIGURE_FLAGS='YACC=false' $MAKE -e distcheck
+$MAKE distcheck YACC=false DISTCHECK_CONFIGURE_FLAGS='YACC=false'
 
 :

diff --git a/tests/yacc-bison-skeleton.test b/tests/yacc-bison-skeleton.test
index aa606585aba1cfb3e53764b402c7f5509e21000e..2b368385ff128812b054826b47e49001e156df39 100755 (executable)
--- a/tests/yacc-bison-skeleton.test
+++ b/tests/yacc-bison-skeleton.test
@@ -69,6 +69,6 @@ $MAKE
 
 # Check that distribution is self-contained, and do not require
 # bison to be built.
-env YACC=false DISTCHECK_CONFIGURE_FLAGS='YACC=false' $MAKE -e distcheck
+$MAKE YACC=false DISTCHECK_CONFIGURE_FLAGS='YACC=false' distcheck
 
 :

diff --git a/tests/yacc-nodist.test b/tests/yacc-nodist.test
index 619ed878b0a09540784438d946751f515b5a9d60..7bfd886f4c261a01e9a7ab87945dccf2521d9105 100755 (executable)
--- a/tests/yacc-nodist.test
+++ b/tests/yacc-nodist.test
@@ -97,8 +97,7 @@ $MAKE test-build
 $MAKE test-dist
 
 # But the distribution must work correctly, assuming the user has
-# the proper tools to process yacc files.  Do this check only with
-# GNU make, to avoid tripping on automake bug#7884.
-if using_gmake; then $MAKE distcheck; fi
+# the proper tools to process yacc files.
+$MAKE distcheck
 
 :