]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
bpf: avoid possible null deref in btf_ext_output [PR target/117447]
authorDavid Faust <david.faust@oracle.com>
Thu, 7 Nov 2024 17:27:07 +0000 (09:27 -0800)
committerDavid Faust <david.faust@oracle.com>
Thu, 7 Nov 2024 17:58:03 +0000 (09:58 -0800)
The BPF-specific .BTF.ext section is always generated for BPF programs
if -gbtf is specified, and generating it requires BTF information and
assumes that the BTF info has already been generated.

Compiling non-C languages to BPF is not supported, nor is generating
CTF/BTF for non-C.  But, compiling another language like C++ to BPF
with -gbtf specified meant that we would try to generate the .BTF.ext
section anyway, and then ICE because no BTF information was available.

Add a check to bail out of btf_ext_output if the TU CTFC does not exist,
meaning no BTF info is available.

gcc/
PR target/117447
* config/bpf/btfext-out.cc (btf_ext_output): Bail if TU CTFC is null.

gcc/config/bpf/btfext-out.cc

index ca6241aa52eee9d4ef5070bf8d478ae1bafcd26d..760b2b59ff6a311b3d0169198f38a9ce4b4b0464 100644 (file)
@@ -611,6 +611,9 @@ btf_ext_init (void)
 void
 btf_ext_output (void)
 {
+  if (!ctf_get_tu_ctfc ())
+    return;
+
   output_btfext_header ();
   output_btfext_func_info (btf_ext);
   if (TARGET_BPF_CORE)