HID: core: do not bypass hid_hw_raw_request

commit c2ca42f190b6714d6c481dfd3d9b62ea091c946b upstream.

hid_hw_raw_request() is actually useful to ensure the provided buffer
and length are valid. Directly calling in the low level transport driver
function bypassed those checks and allowed invalid paramto be used.

Reported-by: Alan Stern <stern@rowland.harvard.edu>
Closes: https://lore.kernel.org/linux-input/c75433e0-9b47-4072-bbe8-b1d14ea97b13@rowland.harvard.edu/
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250710-report-size-null-v2-3-ccf922b7c4e5@kernel.org
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 5d2fc2f403f001e86b07f53615e2c3d222d0fbdc..266cd56dec505651a88e1a407cd4c41aa78bfe5b 100644 (file)
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1961,8 +1961,7 @@ int __hid_request(struct hid_device *hid, struct hid_report *report,
        if (reqtype == HID_REQ_SET_REPORT)
                hid_output_report(report, data_buf);
 
-       ret = hid->ll_driver->raw_request(hid, report->id, buf, len,
-                                         report->type, reqtype);
+       ret = hid_hw_raw_request(hid, report->id, buf, len, report->type, reqtype);
        if (ret < 0) {
                dbg_hid("unable to complete request: %d\n", ret);
                goto out;