[#1982] code cleanup

diff --git a/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.cc b/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.cc
index d0955d4fa5a8755bff664b81a7ec72dfcd94c469..6eb579d9c8cdafcb951cb3b69a32d7b96a4d930b 100644 (file)
--- a/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.cc
+++ b/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.cc
@@ -3676,7 +3676,7 @@ MySqlConfigBackendDHCPv4::isUnusable() {
 
 DatabaseConnection::ParameterMap
 MySqlConfigBackendDHCPv4::getParameters() const {
-    return impl_->getParameters();
+    return (impl_->getParameters());
 }
 
 Subnet4Ptr

diff --git a/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp6.cc b/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp6.cc
index 48668e9b663f25da6f91b32e8b860a8fc78a10d3..2955f973e73dfd99866fee22762e0532661a915a 100644 (file)
--- a/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp6.cc
+++ b/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp6.cc
@@ -4141,7 +4141,7 @@ MySqlConfigBackendDHCPv6::isUnusable() {
 
 DatabaseConnection::ParameterMap
 MySqlConfigBackendDHCPv6::getParameters() const {
-    return impl_->getParameters();
+    return (impl_->getParameters());
 }
 
 Subnet6Ptr

diff --git a/src/lib/dhcpsrv/mysql_host_data_source.cc b/src/lib/dhcpsrv/mysql_host_data_source.cc
index a2c9b60992b35ad2abf48727c848096f1701f784..9deaa960dbe0a7bb5eb62fafd8b3289b45f4e09e 100644 (file)
--- a/src/lib/dhcpsrv/mysql_host_data_source.cc
+++ b/src/lib/dhcpsrv/mysql_host_data_source.cc
@@ -2067,7 +2067,7 @@ public:
     MySqlHostDataSourceImpl(const DatabaseConnection::ParameterMap& parameters);
 
     /// @brief Destructor.
-    ~MySqlHostDataSourceImpl();
+    ~MySqlHostDataSourceImpl() = default;
 
     /// @brief Attempts to reconnect the server to the host DB backend manager.
     ///
@@ -2849,9 +2849,6 @@ MySqlHostDataSourceImpl::createContext() const {
     return (ctx);
 }
 
-MySqlHostDataSourceImpl::~MySqlHostDataSourceImpl() {
-}
-
 bool
 MySqlHostDataSourceImpl::dbReconnect(ReconnectCtlPtr db_reconnect_ctl) {
     MultiThreadingCriticalSection cs;
@@ -3159,12 +3156,9 @@ MySqlHostDataSource::MySqlHostDataSource(const DatabaseConnection::ParameterMap&
     : impl_(new MySqlHostDataSourceImpl(parameters)) {
 }
 
-MySqlHostDataSource::~MySqlHostDataSource() {
-}
-
 DatabaseConnection::ParameterMap
 MySqlHostDataSource::getParameters() const {
-    return impl_->parameters_;
+    return (impl_->parameters_);
 }
 
 void

diff --git a/src/lib/dhcpsrv/mysql_host_data_source.h b/src/lib/dhcpsrv/mysql_host_data_source.h
index 879eb7e3b6b2a26e1d7f52aeb56b8de4d0cb2c48..3f677f11cd2f53c63b128964a96fa9075c1b35ac 100644 (file)
--- a/src/lib/dhcpsrv/mysql_host_data_source.h
+++ b/src/lib/dhcpsrv/mysql_host_data_source.h
@@ -68,7 +68,7 @@ public:
     /// @brief Virtual destructor.
     ///
     /// Releases prepared MySQL statements used by the backend.
-    virtual ~MySqlHostDataSource();
+    virtual ~MySqlHostDataSource() = default;
 
     /// @brief Return backend parameters
     ///

diff --git a/src/lib/dhcpsrv/pgsql_host_data_source.cc b/src/lib/dhcpsrv/pgsql_host_data_source.cc
index 9a8a217e1f35ace7914b7262ba35a1110b3e0f60..db9204efb21552b02220ff1fb8076b124cdddd32 100644 (file)
--- a/src/lib/dhcpsrv/pgsql_host_data_source.cc
+++ b/src/lib/dhcpsrv/pgsql_host_data_source.cc
@@ -1428,7 +1428,7 @@ public:
     PgSqlHostDataSourceImpl(const DatabaseConnection::ParameterMap& parameters);
 
     /// @brief Destructor.
-    ~PgSqlHostDataSourceImpl();
+    ~PgSqlHostDataSourceImpl() = default;
 
     /// @brief Attempts to reconnect the server to the host DB backend manager.
     ///
@@ -2284,9 +2284,6 @@ PgSqlHostDataSourceImpl::createContext() const {
     return (ctx);
 }
 
-PgSqlHostDataSourceImpl::~PgSqlHostDataSourceImpl() {
-}
-
 bool
 PgSqlHostDataSourceImpl::dbReconnect(ReconnectCtlPtr db_reconnect_ctl) {
     MultiThreadingCriticalSection cs;
@@ -2567,12 +2564,9 @@ PgSqlHostDataSource::PgSqlHostDataSource(const DatabaseConnection::ParameterMap&
     : impl_(new PgSqlHostDataSourceImpl(parameters)) {
 }
 
-PgSqlHostDataSource::~PgSqlHostDataSource() {
-}
-
 DatabaseConnection::ParameterMap
 PgSqlHostDataSource::getParameters() const {
-    return impl_->parameters_;
+    return (impl_->parameters_);
 }
 
 void

diff --git a/src/lib/dhcpsrv/pgsql_host_data_source.h b/src/lib/dhcpsrv/pgsql_host_data_source.h
index 1abada5757e3236e5bf48cd49d2dd70fa403f24b..a62e109ab799948c308d53541d9d48de1aaf1720 100644 (file)
--- a/src/lib/dhcpsrv/pgsql_host_data_source.h
+++ b/src/lib/dhcpsrv/pgsql_host_data_source.h
@@ -73,7 +73,7 @@ public:
     ///
     /// Frees database resources and closes the database connection through
     /// the destruction of member impl_.
-    virtual ~PgSqlHostDataSource();
+    virtual ~PgSqlHostDataSource() = default;
 
     /// @brief Return backend parameters
     ///