maint: enforce correct copyright usage

To ensure we don't regress and cause the need for further
cleanups, add a 'make syntax-check' rule that ensures new
files have proper copyright contents.

* cfg.mk (sc_copyright_address): Rename...
(sc_copyright_usage): ...and enhance.

Signed-off-by: Eric Blake <eblake@redhat.com>

diff --git a/cfg.mk b/cfg.mk
index e013195e4fa61a5cfb7f2277af3eb9cc9b0cdfc6..639ac8348f261330be775d1cf9010e759f77c3a9 100644 (file)
--- a/cfg.mk
+++ b/cfg.mk
@@ -682,11 +682,22 @@ sc_copyright_format:
          $(_sc_search_regexp)
 
 # Prefer the new URL listing over the old street address listing when
-# calling out where to get a copy of the [L]GPL.
-sc_copyright_address:
+# calling out where to get a copy of the [L]GPL.  Also, while we have
+# to ship COPYING (GPL) alongside COPYING.LESSER (LGPL), we want any
+# source file that calls out a top-level file to call out the LGPL
+# version.  Note that our typical copyright boilerplate refers to the
+# license by name, not by reference to a top-level file.
+sc_copyright_usage:
        @prohibit=Boston,' MA'                                          \
        halt='Point to <http://www.gnu.org/licenses/>, not an address'  \
          $(_sc_search_regexp)
+       @require='COPYING\.LESSER'                                      \
+       containing='COPYING'                                            \
+       halt='Refer to COPYING.LESSER for LGPL'                         \
+         $(_sc_search_regexp)
+       @prohibit='COPYING\.LIB'                                        \
+       halt='Refer to COPYING.LESSER for LGPL'                         \
+         $(_sc_search_regexp)
 
 # Some functions/macros produce messages intended solely for developers
 # and maintainers.  Do not mark them for translation.
@@ -853,7 +864,7 @@ exclude_file_name_regexp--sc_avoid_write = \
 
 exclude_file_name_regexp--sc_bindtextdomain = ^(tests|examples)/
 
-exclude_file_name_regexp--sc_copyright_address = \
+exclude_file_name_regexp--sc_copyright_usage = \
   ^COPYING(|\.LESSER)$$
 
 exclude_file_name_regexp--sc_flags_usage = ^(docs/|src/util/virnetdevtap\.c$$|tests/vircgroupmock\.c$$)