Reordering of RRTYPE switch case for performance.

diff --git a/src/app-layer-dns-common.c b/src/app-layer-dns-common.c
index 83105e4cc0b62bbc906ab8faa75be2c025a9cad0..d74547ba21d96c9009bb4b7271f4bc57639cf45e 100644 (file)
--- a/src/app-layer-dns-common.c
+++ b/src/app-layer-dns-common.c
@@ -1016,35 +1016,50 @@ void DNSCreateTypeString(uint16_t type, char *str, size_t str_size)
         case DNS_RECORD_TYPE_NS:
             snprintf(str, str_size, "NS");
             break;
-        case DNS_RECORD_TYPE_MD:
-            snprintf(str, str_size, "MD");
-            break;
-        case DNS_RECORD_TYPE_MF:
-            snprintf(str, str_size, "MF");
+        case DNS_RECORD_TYPE_AAAA:
+            snprintf(str, str_size, "AAAA");
             break;
         case DNS_RECORD_TYPE_CNAME:
             snprintf(str, str_size, "CNAME");
             break;
+        case DNS_RECORD_TYPE_TXT:
+            snprintf(str, str_size, "TXT");
+            break;
+        case DNS_RECORD_TYPE_MX:
+            snprintf(str, str_size, "MX");
+            break;
         case DNS_RECORD_TYPE_SOA:
             snprintf(str, str_size, "SOA");
             break;
-        case DNS_RECORD_TYPE_MB:
-            snprintf(str, str_size, "MB");
-            break;
-        case DNS_RECORD_TYPE_MG:
-            snprintf(str, str_size, "MG");
+        case DNS_RECORD_TYPE_PTR:
+            snprintf(str, str_size, "PTR");
             break;
-        case DNS_RECORD_TYPE_MR:
-            snprintf(str, str_size, "MR");
+        case DNS_RECORD_TYPE_SIG:
+            snprintf(str, str_size, "SIG");
             break;
-        case DNS_RECORD_TYPE_NULL:
-            snprintf(str, str_size, "NULL");
+        case DNS_RECORD_TYPE_KEY:
+            snprintf(str, str_size, "KEY");
             break;
         case DNS_RECORD_TYPE_WKS:
             snprintf(str, str_size, "WKS");
             break;
-        case DNS_RECORD_TYPE_PTR:
-            snprintf(str, str_size, "PTR");
+        case DNS_RECORD_TYPE_TKEY:
+            snprintf(str, str_size, "TKEY");
+            break;
+        case DNS_RECORD_TYPE_TSIG:
+            snprintf(str, str_size, "TSIG");
+            break;
+        case DNS_RECORD_TYPE_ANY:
+            snprintf(str, str_size, "ANY");
+            break;
+        case DNS_RECORD_TYPE_RRSIG:
+            snprintf(str, str_size, "RRSIG");
+            break;
+        case DNS_RECORD_TYPE_NSEC:
+            snprintf(str, str_size, "NSEC");
+            break;
+        case DNS_RECORD_TYPE_DNSKEY:
+            snprintf(str, str_size, "DNSKEY");
             break;
         case DNS_RECORD_TYPE_HINFO:
             snprintf(str, str_size, "HINFO");
@@ -1052,12 +1067,6 @@ void DNSCreateTypeString(uint16_t type, char *str, size_t str_size)
         case DNS_RECORD_TYPE_MINFO:
             snprintf(str, str_size, "MINFO");
             break;
-        case DNS_RECORD_TYPE_MX:
-            snprintf(str, str_size, "MX");
-            break;
-        case DNS_RECORD_TYPE_TXT:
-            snprintf(str, str_size, "TXT");
-            break;
         case DNS_RECORD_TYPE_RP:
             snprintf(str, str_size, "RP");
             break;
@@ -1079,27 +1088,15 @@ void DNSCreateTypeString(uint16_t type, char *str, size_t str_size)
         case DNS_RECORD_TYPE_NSAPPTR:
             snprintf(str, str_size, "NSAPPTR");
             break;
-        case DNS_RECORD_TYPE_SIG:
-            snprintf(str, str_size, "SIG");
-            break;
-        case DNS_RECORD_TYPE_KEY:
-            snprintf(str, str_size, "KEY");
-            break;
         case DNS_RECORD_TYPE_PX:
             snprintf(str, str_size, "PX");
             break;
         case DNS_RECORD_TYPE_GPOS:
             snprintf(str, str_size, "GPOS");
             break;
-        case DNS_RECORD_TYPE_AAAA:
-            snprintf(str, str_size, "AAAA");
-            break;
         case DNS_RECORD_TYPE_LOC:
             snprintf(str, str_size, "LOC");
             break;
-        case DNS_RECORD_TYPE_NXT:
-            snprintf(str, str_size, "NXT");
-            break;
         case DNS_RECORD_TYPE_SRV:
             snprintf(str, str_size, "SRV");
             break;
@@ -1136,15 +1133,6 @@ void DNSCreateTypeString(uint16_t type, char *str, size_t str_size)
         case DNS_RECORD_TYPE_IPSECKEY:
             snprintf(str, str_size, "IPSECKEY");
             break;
-        case DNS_RECORD_TYPE_RRSIG:
-            snprintf(str, str_size, "RRSIG");
-            break;
-        case DNS_RECORD_TYPE_NSEC:
-            snprintf(str, str_size, "NSEC");
-            break;
-        case DNS_RECORD_TYPE_DNSKEY:
-            snprintf(str, str_size, "DNSKEY");
-            break;
         case DNS_RECORD_TYPE_DHCID:
             snprintf(str, str_size, "DHCID");
             break;
@@ -1166,24 +1154,36 @@ void DNSCreateTypeString(uint16_t type, char *str, size_t str_size)
         case DNS_RECORD_TYPE_CDNSKEY:
             snprintf(str, str_size, "CDNSKEY");
             break;
-        case DNS_RECORD_TYPE_SPF:
-            snprintf(str, str_size, "SPF");
-            break;
-        case DNS_RECORD_TYPE_TKEY:
-            snprintf(str, str_size, "TKEY");
-            break;
-        case DNS_RECORD_TYPE_TSIG:
-            snprintf(str, str_size, "TSIG");
-            break;
         case DNS_RECORD_TYPE_MAILA:
             snprintf(str, str_size, "MAILA");
             break;
-        case DNS_RECORD_TYPE_ANY:
-            snprintf(str, str_size, "ANY");
-            break;
         case DNS_RECORD_TYPE_URI:
             snprintf(str, str_size, "URI");
             break;
+        case DNS_RECORD_TYPE_MB:
+            snprintf(str, str_size, "MB");
+            break;
+        case DNS_RECORD_TYPE_MG:
+            snprintf(str, str_size, "MG");
+            break;
+        case DNS_RECORD_TYPE_MR:
+            snprintf(str, str_size, "MR");
+            break;
+        case DNS_RECORD_TYPE_NULL:
+            snprintf(str, str_size, "NULL");
+            break;
+        case DNS_RECORD_TYPE_SPF:
+            snprintf(str, str_size, "SPF");
+            break;
+        case DNS_RECORD_TYPE_NXT:
+            snprintf(str, str_size, "NXT");
+            break;
+        case DNS_RECORD_TYPE_MD:
+            snprintf(str, str_size, "MD");
+            break;
+        case DNS_RECORD_TYPE_MF:
+            snprintf(str, str_size, "MF");
+            break;
         default:
             snprintf(str, str_size, "%04x/%u", type, type);
     }