ASoC: qcom: audioreach: Fix confusing cleanup.h syntax

Commit 88a5f8e628ef ("ASoc: qcom: audioreach: Use automatic cleanup of
kfree()") did not make the code simpler but more complicated.  Already
simple code of allocation and free, without any error paths, got now
declaration with one constructor followed by another allocation, which
is in contrary to explicit coding rules guiding cleanup.h:

"Given that the "__free(...) = NULL" pattern for variables defined at
the top of the function poses this potential interdependency problem the
recommendation is to always define and assign variables in one statement
and not group variable definitions at the top of the function when
__free() is used."

Code does not have a bug, but is less readable and uses discouraged
coding practice, so fix that by moving declaration to the place of
assignment.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-5-c38b06884e39@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audioreach.c
index ded49124581bf421ff63a2c7508b5a82d6a7f9e7..329d916779f00116452d7d504797fa3182707563 100644 (file)
--- a/sound/soc/qcom/qdsp6/audioreach.c
+++ b/sound/soc/qcom/qdsp6/audioreach.c
@@ -730,15 +730,15 @@ int audioreach_send_u32_param(struct q6apm_graph *graph, struct audioreach_modul
                              uint32_t param_id, uint32_t param_val)
 {
        struct apm_module_param_data *param_data;
-       struct gpr_pkt *pkt __free(kfree) = NULL;
        uint32_t *param;
        int payload_size = sizeof(uint32_t) + APM_MODULE_PARAM_DATA_SIZE;
-       void *p = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);
-       if (IS_ERR(p))
+       void *p;
+
+       struct gpr_pkt *pkt __free(kfree) = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);
+       if (IS_ERR(pkt))
                return -ENOMEM;
 
-       pkt = p;
-       p = p + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+       p = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
 
        param_data = p;
        param_data->module_instance_id = module->instance_id;
@@ -1043,7 +1043,6 @@ static int audioreach_pcm_set_media_format(struct q6apm_graph *graph,
        struct apm_pcm_module_media_fmt_cmd *cfg;
        struct apm_module_param_data *param_data;
        int payload_size;
-       struct gpr_pkt *pkt __free(kfree) = NULL;
 
        if (num_channels > 4) {
                dev_err(graph->dev, "Error: Invalid channels (%d)!\n", num_channels);
@@ -1052,7 +1051,8 @@ static int audioreach_pcm_set_media_format(struct q6apm_graph *graph,
 
        payload_size = APM_PCM_MODULE_FMT_CMD_PSIZE(num_channels);
 
-       pkt = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);
+       struct gpr_pkt *pkt __free(kfree) =
+               audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);
        if (IS_ERR(pkt))
                return PTR_ERR(pkt);
 
@@ -1090,7 +1090,6 @@ static int audioreach_shmem_set_media_format(struct q6apm_graph *graph,
        struct payload_media_fmt_pcm *cfg;
        struct media_format *header;
        int rc, payload_size;
-       struct gpr_pkt *pkt __free(kfree) = NULL;
        void *p;
 
        if (num_channels > 4) {
@@ -1100,8 +1099,9 @@ static int audioreach_shmem_set_media_format(struct q6apm_graph *graph,
 
        payload_size = APM_SHMEM_FMT_CFG_PSIZE(num_channels) + APM_MODULE_PARAM_DATA_SIZE;
 
-       pkt = audioreach_alloc_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0,
-                                    graph->port->id, module->instance_id);
+       struct gpr_pkt *pkt __free(kfree) =
+               audioreach_alloc_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0,
+                                        graph->port->id, module->instance_id);
        if (IS_ERR(pkt))
                return PTR_ERR(pkt);