Use RefCount::dereference() correctly in move assignment

The dereference() member is actually an update operation on the stored
pointer. We can and should just use it to steal the others pointer
instead of using it on our own then stealing.

diff --git a/src/base/RefCount.h b/src/base/RefCount.h
index 32ef2db6751d536362b5562bf6f8d18fbd5c9f80..18b6cfb9889836021095ccc703d4a5c31f62b8a0 100644 (file)
--- a/src/base/RefCount.h
+++ b/src/base/RefCount.h
@@ -54,8 +54,7 @@ public:
 
     RefCount& operator = (RefCount&& p) {
         if (this != &p) {
-            dereference(p_);
-            p_ = std::move(p.p_);
+            dereference(p.p_);
             p.p_ = NULL;
         }
         return *this;