]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: mpt3sas: Drop unused variable in mpt3sas_send_mctp_passthru_req()
authorAndré Draszik <andre.draszik@linaro.org>
Fri, 6 Jun 2025 15:29:43 +0000 (16:29 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 16 Jun 2025 18:23:50 +0000 (14:23 -0400)
With W=1, gcc complains correctly:

    mpt3sas_ctl.c: In function ‘mpt3sas_send_mctp_passthru_req’:
    mpt3sas_ctl.c:2917:29: error: variable ‘mpi_reply’ set but not used [-Werror=unused-but-set-variable]
     2917 |         MPI2DefaultReply_t *mpi_reply;
          |                             ^~~~~~~~~

Drop the unused assignment and variable.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/20250606-mpt3sas-v1-1-906ffe49fb6b@linaro.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_ctl.c

index 02fc204b9bf7b276115bf6db52746155381799fd..3b951589feeb6c13094ea44b494ca3050a309b15 100644 (file)
@@ -2914,7 +2914,6 @@ int mpt3sas_send_mctp_passthru_req(struct mpt3_passthru_command *command)
 {
        struct MPT3SAS_ADAPTER *ioc;
        MPI2RequestHeader_t *mpi_request = NULL, *request;
-       MPI2DefaultReply_t *mpi_reply;
        Mpi26MctpPassthroughRequest_t *mctp_passthru_req;
        u16 smid;
        unsigned long timeout;
@@ -3022,8 +3021,6 @@ int mpt3sas_send_mctp_passthru_req(struct mpt3_passthru_command *command)
                goto issue_host_reset;
        }
 
-       mpi_reply = ioc->ctl_cmds.reply;
-
        /* copy out xdata to user */
        if (data_in_sz)
                memcpy(command->data_in_buf_ptr, data_in, data_in_sz);