]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
selection: don't query asynchronously, as it creates problems
authorŠtěpán Balážik <stepan.balazik@nic.cz>
Thu, 10 Sep 2020 11:33:53 +0000 (13:33 +0200)
committerŠtěpán Balážik <stepan.balazik@nic.cz>
Thu, 15 Oct 2020 11:22:22 +0000 (13:22 +0200)
I can't see a simple way to prevent cycles.
Also, there were some weird memory leaks caused by it.

lib/selection_iter.c

index 5628f2549fcc430f4638366c78f954e76136b576..9ec0f8e7dbed315da41c452b087bc0aa1064ad73 100644 (file)
@@ -187,11 +187,6 @@ void iter_choose_transport(struct kr_query *qry, struct kr_transport **transport
 
        trie_it_free(it);
 
-       if (to_resolve) {
-               qry->request->selection_context.async_ns_resolution(unresolved_names[0], KNOT_RRTYPE_AAAA);
-               qry->request->selection_context.async_ns_resolution(unresolved_names[0], KNOT_RRTYPE_A);
-       }
-
        if (valid_addresses || to_resolve) {
                bool tcp = qry->flags.TCP | qry->server_selection.truncated;
                *transport = choose_transport(choices, valid_addresses, unresolved_names, to_resolve, qry->server_selection.timeouts, mempool, tcp, NULL);