]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/vc4: hdmi: replace use of system_wq with system_percpu_wq
authorMarco Crivellari <marco.crivellari@suse.com>
Wed, 5 Nov 2025 10:11:34 +0000 (11:11 +0100)
committerMaíra Canal <mcanal@igalia.com>
Mon, 16 Feb 2026 11:22:09 +0000 (08:22 -0300)
Currently if a user enqueues a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

This patch continues the effort to refactor worqueue APIs, which has begun
with the change introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

system_wq should be the per-cpu workqueue, yet in this name nothing makes
that clear, so replace system_wq with system_percpu_wq.

The old wq (system_wq) will be kept for a few release cycles.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Link: https://patch.msgid.link/20251105101134.82064-1-marco.crivellari@suse.com
Signed-off-by: Maíra Canal <mcanal@igalia.com>
drivers/gpu/drm/vc4/vc4_hdmi.c

index 9fe605a42df73014eaacb57a36697c5c6e3c5d3b..00409c5f5ef8626c6a17a456bf5b66b6cbd74190 100644 (file)
@@ -823,7 +823,7 @@ static void vc4_hdmi_enable_scrambling(struct drm_encoder *encoder)
 
        vc4_hdmi->scdc_enabled = true;
 
-       queue_delayed_work(system_wq, &vc4_hdmi->scrambling_work,
+       queue_delayed_work(system_percpu_wq, &vc4_hdmi->scrambling_work,
                           msecs_to_jiffies(SCRAMBLING_POLLING_DELAY_MS));
 }
 
@@ -872,7 +872,7 @@ static void vc4_hdmi_scrambling_wq(struct work_struct *work)
        drm_scdc_set_high_tmds_clock_ratio(connector, true);
        drm_scdc_set_scrambling(connector, true);
 
-       queue_delayed_work(system_wq, &vc4_hdmi->scrambling_work,
+       queue_delayed_work(system_percpu_wq, &vc4_hdmi->scrambling_work,
                           msecs_to_jiffies(SCRAMBLING_POLLING_DELAY_MS));
 }