dnsdist: Fix crash when calling rmServer() with an invalid index

Fix #3460.

diff --git a/pdns/dnsdist-lua.cc b/pdns/dnsdist-lua.cc
index d11463478747cd19eabb370ff5ee8edab7353714..fdde7611be35a54151acb18a7db6f4a93fe52956 100644 (file)
--- a/pdns/dnsdist-lua.cc
+++ b/pdns/dnsdist-lua.cc
@@ -394,12 +394,14 @@ vector<std::function<void(void)>> setupLua(bool client, const std::string& confi
                         }
                         else {
                           int idx = boost::get<int>(var);
-                          server = states[idx];
+                          server = states.at(idx);
                         }
                         auto localPools = g_pools.getCopy();
                         for (const string& poolName : server->pools) {
                           removeServerFromPool(localPools, poolName, server);
                         }
+                        /* the server might also be in the default pool */
+                        removeServerFromPool(localPools, "", server);
                         g_pools.setState(localPools);
                         states.erase(remove(states.begin(), states.end(), server), states.end());
                         g_dstates.setState(states);