wifi: ath9k: do not submit zero bytes to the entropy pool

In 'ath_cmn_process_fft()', it doesn't make too much sense to
add zero bytes in attempt to improve randomness. So swap calls
to 'memset()' and 'add_device_randomness()' to feed the pool
with actual FFT results rather than zeroes. Compile tested only.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Fixes: 2aa56cca3571 ("ath9k: Mix the received FFT bins to the random pool")
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Link: https://patch.msgid.link/20250123141058.1696502-1-dmantipov@yandex.ru
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>

diff --git a/drivers/net/wireless/ath/ath9k/common-spectral.c b/drivers/net/wireless/ath/ath9k/common-spectral.c
index 628eeec4b82fe8c6d21d2f3d6fcd339e41f36e65..300d178830adf6aeda9bda6db2ef31becce9c917 100644 (file)
--- a/drivers/net/wireless/ath/ath9k/common-spectral.c
+++ b/drivers/net/wireless/ath/ath9k/common-spectral.c
@@ -628,12 +628,12 @@ int ath_cmn_process_fft(struct ath_spec_scan_priv *spec_priv, struct ieee80211_h
                                else
                                        RX_STAT_INC(sc, rx_spectral_sample_err);
 
-                               memset(sample_buf, 0, SPECTRAL_SAMPLE_MAX_LEN);
-
                                /* Mix the received bins to the /dev/random
                                 * pool
                                 */
                                add_device_randomness(sample_buf, num_bins);
+
+                               memset(sample_buf, 0, SPECTRAL_SAMPLE_MAX_LEN);
                        }
 
                        /* Process a normal frame */