]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
dsdb/mod/acl_util: do not deref NULL sd_flags control
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 23 Apr 2020 03:31:13 +0000 (15:31 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Sat, 13 Jun 2020 05:25:31 +0000 (05:25 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/samdb/ldb_modules/acl_util.c

index b9931795e19f9fffe3ac76580fb135a5e2597880..f917d99517a4dc3ed540ad7f4aec26130f24fe0a 100644 (file)
@@ -257,7 +257,7 @@ uint32_t dsdb_request_sd_flags(struct ldb_request *req, bool *explicit)
        }
 
        sd_control = ldb_request_get_control(req, LDB_CONTROL_SD_FLAGS_OID);
-       if (sd_control) {
+       if (sd_control != NULL && sd_control->data != NULL) {
                struct ldb_sd_flags_control *sdctr = (struct ldb_sd_flags_control *)sd_control->data;
 
                sd_flags = sdctr->secinfo_flags;