]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
kernel: allow fork with TIF_NOTIFY_SIGNAL pending
authorJens Axboe <axboe@kernel.dk>
Mon, 22 Mar 2021 15:39:12 +0000 (09:39 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jan 2023 10:39:22 +0000 (11:39 +0100)
[ Upstream commit 66ae0d1e2d9fe6ec70e73fcfdcf4b390e271c1ac ]

fork() fails if signal_pending() is true, but there are two conditions
that can lead to that:

1) An actual signal is pending. We want fork to fail for that one, like
   we always have.

2) TIF_NOTIFY_SIGNAL is pending, because the task has pending task_work.
   We don't need to make it fail for that case.

Allow fork() to proceed if just task_work is pending, by changing the
signal_pending() check to task_sigpending().

Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/fork.c

index 252a40f14f72614f04520f33a9e8b08cc7124da0..b5cd5cdd3e6784bcc113f94b42f6e7a564f2bcd4 100644 (file)
@@ -1942,7 +1942,7 @@ static __latent_entropy struct task_struct *copy_process(
        recalc_sigpending();
        spin_unlock_irq(&current->sighand->siglock);
        retval = -ERESTARTNOINTR;
-       if (signal_pending(current))
+       if (task_sigpending(current))
                goto fork_out;
 
        retval = -ENOMEM;