Merged revisions 303546 via svnmerge from

https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r303546 | russell | 2011-01-24 14:32:21 -0600 (Mon, 24 Jan 2011) | 31 lines

  Fix channel redirect out of MeetMe() and other issues with channel softhangup.

  Mantis issue #18585 reports that a channel redirect out of MeetMe() stopped
  working properly.  This issue includes a patch that resolves the issue by
  removing a call to ast_check_hangup() from app_meetme.c.  I left that in my
  patch, as it doesn't need to be there.  However, the rest of the patch fixes
  this problem with or without the change to app_meetme.

  The key difference between what happens before and after this patch is the
  effect of the END_OF_Q control frame.  After END_OF_Q is hit in ast_read(),
  ast_read() will return NULL.  With the ast_check_hangup() removed, app_meetme
  sees this which causes it to exit as intended.  Checking ast_check_hangup()
  caused app_meetme to exit earlier in the process, and the target of the
  redirect saw the condition where ast_read() returned NULL.

  Removing ast_check_hangup() works around the issue in app_meetme, but doesn't
  solve the issue if another application did the same thing.  There are also
  other edge cases where if an application finishes at the same time that a
  redirect happens, the target of the redirect will think that the channel hung
  up.  So, I made some changes in pbx.c to resolve it at a deeper level.  There
  are already places that unset the SOFTHANGUP_ASYNCGOTO flag in an attempt to
  abort the hangup process.  My patch extends this to remove the END_OF_Q frame
  from the channel's read queue, making the "abort hangup" more complete.  This
  same technique was used in every place where a softhangup flag was cleared.

  (closes issue #18585)
  Reported by: oej
  Tested by: oej, wedhorn, russell

  Review: https://reviewboard.asterisk.org/r/1082/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@303548 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/apps/app_meetme.c b/apps/app_meetme.c
index fcf06367029ef285e4662c5a6eb53e5e70b70907..8191df6eb4e3fdfb5e8012c9b708109cb555687a 100644 (file)
--- a/apps/app_meetme.c
+++ b/apps/app_meetme.c
@@ -2909,11 +2909,6 @@ static int conf_run(struct ast_channel *chan, struct ast_conference *conf, int c
                                break;
                        }
 
-                       /* Perform an extra hangup check just in case */
-                       if (ast_check_hangup(chan)) {
-                               break;
-                       }
-
                        c = ast_waitfor_nandfds(&chan, 1, &fd, nfds, NULL, &outfd, &ms);
 
                        if (c) {

diff --git a/include/asterisk/channel.h b/include/asterisk/channel.h
index 11fc9b67c1d98290562a71a7445cbd80fdf87a12..eb5de8590510f86ae0b7891ea14f127dd15db990 100644 (file)
--- a/include/asterisk/channel.h
+++ b/include/asterisk/channel.h
@@ -684,6 +684,15 @@ enum {
         * instead of actually hanging up.
         */
        AST_SOFTHANGUP_UNBRIDGE =  (1 << 6),
+
+
+       /*!
+        * \brief All softhangup flags.
+        *
+        * This can be used as an argument to ast_channel_softhangup_clear
+        * to clear all softhangup flags from a channel.
+        */
+       AST_SOFTHANGUP_ALL =       (0xFFFFFFFF)
 };
 
 
@@ -1013,6 +1022,20 @@ int ast_softhangup(struct ast_channel *chan, int reason);
  */
 int ast_softhangup_nolock(struct ast_channel *chan, int reason);
 
+/*!
+ * \brief Clear a set of softhangup flags from a channel
+ *
+ * Never clear a softhangup flag from a channel directly.  Instead,
+ * use this function.  This ensures that all aspects of the softhangup
+ * process are aborted.
+ *
+ * \param chan the channel to clear the flag on
+ * \param flag the flag or flags to clear
+ *
+ * \return Nothing.
+ */
+void ast_channel_clear_softhangup(struct ast_channel *chan, int flag);
+
 /*! \brief Check to see if a channel is needing hang up
  * \param chan channel on which to check for hang up
  * This function determines if the channel is being requested to be hung up.

diff --git a/main/channel.c b/main/channel.c
index d70c0ea7da4148f3765a9612cc16e88b734282a6..226ef3fdf96c5482de387295131fbd004d854db1 100644 (file)
--- a/main/channel.c
+++ b/main/channel.c
@@ -1744,6 +1744,31 @@ void ast_poll_channel_del(struct ast_channel *chan0, struct ast_channel *chan1)
        return;
 }
 
+void ast_channel_clear_softhangup(struct ast_channel *chan, int flag)
+{
+       ast_channel_lock(chan);
+
+       chan->_softhangup &= ~flag;
+
+       if (!chan->_softhangup) {
+               struct ast_frame *fr;
+
+               /* If we have completely cleared the softhangup flag,
+                * then we need to fully abort the hangup process.  This requires
+                * pulling the END_OF_Q frame out of the channel frame queue if it
+                * still happens to be there. */
+
+               fr = AST_LIST_LAST(&chan->readq);
+               if (fr && fr->frametype == AST_FRAME_CONTROL &&
+                               fr->subclass == AST_CONTROL_END_OF_Q) {
+                       AST_LIST_REMOVE(&chan->readq, fr, frame_list);
+                       ast_frfree(fr);
+               }
+       }
+
+       ast_channel_unlock(chan);
+}
+
 /*! \brief Softly hangup a channel, don't lock */
 int ast_softhangup_nolock(struct ast_channel *chan, int cause)
 {
@@ -5187,10 +5212,10 @@ static enum ast_bridge_result ast_generic_bridge(struct ast_channel *c0, struct
                                ast_jb_get_and_deliver(c0, c1);
                        if ((c0->_softhangup | c1->_softhangup) & AST_SOFTHANGUP_UNBRIDGE) {/* Bit operators are intentional. */
                                if (c0->_softhangup & AST_SOFTHANGUP_UNBRIDGE) {
-                                       c0->_softhangup &= ~AST_SOFTHANGUP_UNBRIDGE;
+                                       ast_channel_clear_softhangup(c0, AST_SOFTHANGUP_UNBRIDGE);
                                }
                                if (c1->_softhangup & AST_SOFTHANGUP_UNBRIDGE) {
-                                       c1->_softhangup &= ~AST_SOFTHANGUP_UNBRIDGE;
+                                       ast_channel_clear_softhangup(c1, AST_SOFTHANGUP_UNBRIDGE);
                                }
                                c0->_bridge = c1;
                                c1->_bridge = c0;
@@ -5503,10 +5528,10 @@ enum ast_bridge_result ast_channel_bridge(struct ast_channel *c0, struct ast_cha
 
                if ((c0->_softhangup | c1->_softhangup) & AST_SOFTHANGUP_UNBRIDGE) {/* Bit operators are intentional. */
                        if (c0->_softhangup & AST_SOFTHANGUP_UNBRIDGE) {
-                               c0->_softhangup &= ~AST_SOFTHANGUP_UNBRIDGE;
+                               ast_channel_clear_softhangup(c0, AST_SOFTHANGUP_UNBRIDGE);
                        }
                        if (c1->_softhangup & AST_SOFTHANGUP_UNBRIDGE) {
-                               c1->_softhangup &= ~AST_SOFTHANGUP_UNBRIDGE;
+                               ast_channel_clear_softhangup(c1, AST_SOFTHANGUP_UNBRIDGE);
                        }
                        c0->_bridge = c1;
                        c1->_bridge = c0;

diff --git a/main/features.c b/main/features.c
index e67c5fbd94b4317b28b9c23d58fb53af5e92360d..6e90b5ee76e9169ad843124eb1a5da38122ba3c6 100644 (file)
--- a/main/features.c
+++ b/main/features.c
@@ -553,7 +553,7 @@ static void check_goto_on_transfer(struct ast_channel *chan)
        ast_parseable_goto(xferchan, goto_on_transfer);
        xferchan->_state = AST_STATE_UP;
        ast_clear_flag(xferchan, AST_FLAGS_ALL);        
-       xferchan->_softhangup = 0;
+       ast_channel_clear_softhangup(xferchan, AST_SOFTHANGUP_ALL);
        if ((f = ast_read(xferchan))) {
                ast_frfree(f);
                f = NULL;

diff --git a/main/pbx.c b/main/pbx.c
index 88935781f887947fceba6af692c42f20dc6fcc80..49ac156ca9756cd3ee0adea2e506ec1c4009f40a 100644 (file)
--- a/main/pbx.c
+++ b/main/pbx.c
@@ -4253,7 +4253,7 @@ static int collect_digits(struct ast_channel *c, int waittime, char *buf, int bu
                   keep reading digits until we can't possibly get a right answer anymore.  */
                digit = ast_waitfordigit(c, waittime);
                if (c->_softhangup & AST_SOFTHANGUP_ASYNCGOTO) {
-                       c->_softhangup &= ~AST_SOFTHANGUP_ASYNCGOTO;
+                       ast_channel_clear_softhangup(c, AST_SOFTHANGUP_ASYNCGOTO);
                } else {
                        if (!digit)     /* No entry */
                                break;
@@ -4324,14 +4324,14 @@ static enum ast_pbx_result __ast_pbx_run(struct ast_channel *c,
                                set_ext_pri(c, "T", 0); /* 0 will become 1 with the c->priority++; at the end */
                                /* If the AbsoluteTimeout is not reset to 0, we'll get an infinite loop */
                                memset(&c->whentohangup, 0, sizeof(c->whentohangup));
-                               c->_softhangup &= ~AST_SOFTHANGUP_TIMEOUT;
+                               ast_channel_clear_softhangup(c, AST_SOFTHANGUP_TIMEOUT);
                        } else if (c->_softhangup & AST_SOFTHANGUP_TIMEOUT && ast_exists_extension(c, c->context, "e", 1, c->cid.cid_num)) {
                                pbx_builtin_raise_exception(c, "ABSOLUTETIMEOUT");
                                /* If the AbsoluteTimeout is not reset to 0, we'll get an infinite loop */
                                memset(&c->whentohangup, 0, sizeof(c->whentohangup));
-                               c->_softhangup &= ~AST_SOFTHANGUP_TIMEOUT;
+                               ast_channel_clear_softhangup(c, AST_SOFTHANGUP_TIMEOUT);
                        } else if (c->_softhangup & AST_SOFTHANGUP_ASYNCGOTO) {
-                               c->_softhangup &= ~AST_SOFTHANGUP_ASYNCGOTO;
+                               ast_channel_clear_softhangup(c, AST_SOFTHANGUP_ASYNCGOTO);
                                continue;
                        } else if (ast_check_hangup(c)) {
                                ast_debug(1, "Extension %s, priority %d returned normally even though call was hung up\n",
@@ -4376,13 +4376,13 @@ static enum ast_pbx_result __ast_pbx_run(struct ast_channel *c,
                                }
 
                                if (c->_softhangup & AST_SOFTHANGUP_ASYNCGOTO) {
-                                       c->_softhangup &= ~AST_SOFTHANGUP_ASYNCGOTO;
+                                       ast_channel_clear_softhangup(c, AST_SOFTHANGUP_ASYNCGOTO);
                                        continue;
                                } else if (c->_softhangup & AST_SOFTHANGUP_TIMEOUT && ast_exists_extension(c, c->context, "T", 1, c->cid.cid_num)) {
                                        set_ext_pri(c, "T", 1);
                                        /* If the AbsoluteTimeout is not reset to 0, we'll get an infinite loop */
                                        memset(&c->whentohangup, 0, sizeof(c->whentohangup));
-                                       c->_softhangup &= ~AST_SOFTHANGUP_TIMEOUT;
+                                       ast_channel_clear_softhangup(c, AST_SOFTHANGUP_TIMEOUT);
                                        continue;
                                } else {
                                        if (c->cdr)
@@ -4420,7 +4420,7 @@ static enum ast_pbx_result __ast_pbx_run(struct ast_channel *c,
                        }
                } else if (c->_softhangup & AST_SOFTHANGUP_TIMEOUT) {
                        /* If we get this far with AST_SOFTHANGUP_TIMEOUT, then we know that the "T" extension is next. */
-                       c->_softhangup &= ~AST_SOFTHANGUP_TIMEOUT;
+                       ast_channel_clear_softhangup(c, AST_SOFTHANGUP_TIMEOUT);
                } else {        /* keypress received, get more digits for a full extension */
                        int waittime = 0;
                        if (digit)