]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
usb: misc: appledisplay: use HID includes
authorOliver Neukum <oneukum@suse.com>
Wed, 25 Mar 2026 17:12:56 +0000 (18:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 30 Mar 2026 14:47:26 +0000 (16:47 +0200)
The driver uses its own definitions for HID requests.
This leads to duplication and obfuscation. Use HID's
definitions.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Link: https://patch.msgid.link/20260325171311.384010-1-oneukum@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/appledisplay.c

index 4beebde598428b464fcf36805510ea6a19f83843..16883592f7fc698ae1ca127bfd52204100e7ed97 100644 (file)
@@ -12,6 +12,7 @@
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/slab.h>
+#include <linux/hid.h>
 #include <linux/usb.h>
 #include <linux/backlight.h>
 #include <linux/timer.h>
@@ -20,9 +21,6 @@
 
 #define APPLE_VENDOR_ID                0x05AC
 
-#define USB_REQ_GET_REPORT     0x01
-#define USB_REQ_SET_REPORT     0x09
-
 #define ACD_USB_TIMEOUT                250
 
 #define ACD_USB_EDID           0x0302
@@ -140,7 +138,7 @@ static int appledisplay_bl_update_status(struct backlight_device *bd)
        retval = usb_control_msg(
                pdata->udev,
                usb_sndctrlpipe(pdata->udev, 0),
-               USB_REQ_SET_REPORT,
+               HID_REQ_SET_REPORT,
                USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE,
                ACD_USB_BRIGHTNESS,
                0,
@@ -163,7 +161,7 @@ static int appledisplay_bl_get_brightness(struct backlight_device *bd)
        retval = usb_control_msg(
                pdata->udev,
                usb_rcvctrlpipe(pdata->udev, 0),
-               USB_REQ_GET_REPORT,
+               HID_REQ_GET_REPORT,
                USB_DIR_IN | USB_TYPE_CLASS | USB_RECIP_INTERFACE,
                ACD_USB_BRIGHTNESS,
                0,