]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: ops: Log unknown controls in snd_soc_limit_volume()
authorMark Brown <broonie@kernel.org>
Wed, 22 Apr 2026 20:34:05 +0000 (21:34 +0100)
committerMark Brown <broonie@kernel.org>
Sun, 26 Apr 2026 21:51:59 +0000 (06:51 +0900)
When we fail to look up the control name in snd_soc_limit_volume() we don't
log anything, the error code isn't particularly descriptive and checking
the return value of the function at all is a bit erratic among the callers.
Since there is no reason why anyone should ever be attempting to limit the
volume of a nonexistant control add a log message in the core to improve
usability.

Link: https://patch.msgid.link/20260422-asoc-limit-volume-error-v2-1-2e2ced321229@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-ops.c

index bbf277670718e22f41a21c94903ee0d675bad476..c935571d43e9d3f94af3a619cf1858763f0e2882 100644 (file)
@@ -461,6 +461,10 @@ int snd_soc_limit_volume(struct snd_soc_card *card, const char *name, int max)
                        mc->platform_max = max;
                        ret = snd_soc_clip_to_platform_max(kctl);
                }
+       } else {
+               /* Some cards blindly add limits for multiple variants. */
+               dev_dbg(card->dev, "Volume limit for unknown control '%s'\n",
+                       name);
        }
 
        return ret;